prop224: Refactor how we use connection_ap_handle_onion

Simply directly return its returned value.

Signed-off-by: David Goulet <dgoulet@torproject.org>

diff --git a/src/or/connection_edge.c b/src/or/connection_edge.c
index 6409c5be81ba457c72dfd110e56a152632773fb1..a98b32450b889b13e4ba62a96cf664e277fbfde8 100644 (file)
--- a/src/or/connection_edge.c
+++ b/src/or/connection_edge.c
@@ -2017,9 +2017,7 @@ connection_ap_handshake_rewrite_and_attach(entry_connection_t *conn,
     tor_assert(addresstype == ONION_V2_HOSTNAME ||
                addresstype == ONION_V3_HOSTNAME);
     tor_assert(!automap);
-    if (connection_ap_handle_onion(conn, socks, circ, addresstype) < 0) {
-      return -1;
-    }
+    return connection_ap_handle_onion(conn, socks, circ, addresstype);
   }
 
   return 0; /* unreached but keeps the compiler happy */