r12053@catbus: nickm | 2007-03-03 16:45:38 -0500

 Remove some XXX012s: leave a check in connection_or_set_identity_digest it costs basically nothing to do on average.  Forget about reinstating the user check on NT Service creation.  Note that a notice message in main.c ("Is something wrong with your network connection?") is really useless.

svn:r9721

diff --git a/src/or/connection_or.c b/src/or/connection_or.c
index 34c890b5ae07a61e6b98b5bdcebacee6dc41658c..13d37fee0c9134a288da47d68fe8e743535adde1 100644 (file)
--- a/src/or/connection_or.c
+++ b/src/or/connection_or.c
@@ -113,7 +113,6 @@ connection_or_set_identity_digest(or_connection_t *conn, const char *digest)
   conn->next_with_same_id = tmp;
 
 #if 1
-  /*XXXX012 change this back to if 0. */
   /* Testing code to check for bugs in representation. */
   for (; tmp; tmp = tmp->next_with_same_id) {
     tor_assert(!memcmp(tmp->identity_digest, digest, DIGEST_LEN));

diff --git a/src/or/main.c b/src/or/main.c
index 9f655b6d53a739c523538667fcc4df6a67c82868..17e1f3e74cb30ba97638c462edaf4481ecf07664 100644 (file)
--- a/src/or/main.c
+++ b/src/or/main.c
@@ -536,6 +536,8 @@ conn_close_if_marked(int i)
         severity = LOG_INFO;
       else
         severity = LOG_NOTICE;
+      /* XXXX012 rewrite this error message; it generates lots of worried
+       * support requests. */
       log_fn(severity, LD_NET, "Something wrong with your network connection? "
              "We tried to write %d bytes to addr %s (fd %d, type %s, state %d)"
              " but timed out. (Marked at %s:%d)",
@@ -2278,7 +2280,7 @@ nt_service_install(int argc, char **argv)
                             NULL, &sidLen, // Don't care about the SID
                             NULL, &domainLen, // Don't care about the domain
                             &sidUse) == 0) {
-    /* XXXX012 For some reason, the above test segfaults. Fix that. */
+    /* XXXX For some reason, the above test segfaults. Fix that. */
     printf("User \"%s\" doesn't seem to exist.\n", user_acct);
     return -1;
   } else {