]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
Replace free and return NULL with return mfree
authorDaniel Lockyer <thisisdaniellockyer@gmail.com>
Fri, 24 Nov 2017 10:31:49 +0000 (10:31 +0000)
committerDaniel Lockyer <thisisdaniellockyer@gmail.com>
Fri, 24 Nov 2017 10:31:49 +0000 (10:31 +0000)
src/basic/khash.c
src/core/transaction.c
src/libsystemd/sd-bus/bus-objects.c
src/libudev/libudev-hwdb.c
src/libudev/libudev-monitor.c
src/libudev/libudev-queue.c
src/libudev/libudev.c
src/shared/condition.c
src/shared/dissect-image.c
src/shared/loop-util.c

index 8122903b09c82444eae12ff33798bbf873301339..694210512cf1bf29e04f91ad99a0635950408ae7 100644 (file)
@@ -127,9 +127,7 @@ khash* khash_unref(khash *h) {
 
         safe_close(h->fd);
         free(h->algorithm);
-        free(h);
-
-        return NULL;
+        return mfree(h);
 }
 
 int khash_dup(khash *h, khash **ret) {
index 52ae664faefecbfefddc26bc63c4e5354f6c63da..32ad660026861fe0d3a5f3eac68d4901eb7a91bf 100644 (file)
@@ -346,8 +346,7 @@ static char* merge_unit_ids(const char* unit_log_field, char **pairs) {
         STRV_FOREACH_PAIR(unit_id, job_type, pairs) {
                 next = strlen(unit_log_field) + strlen(*unit_id);
                 if (!GREEDY_REALLOC(ans, alloc, size + next + 1)) {
-                        free(ans);
-                        return NULL;
+                        return mfree(ans);
                 }
 
                 sprintf(ans + size, "%s%s", unit_log_field, *unit_id);
index 9fb455a94e229bfd92c4b1c785ab1a7ebb1204a4..4c7dbaa2c9d19036cff85d24cc128fdaa2e8433b 100644 (file)
@@ -1476,8 +1476,7 @@ static struct node *bus_node_allocate(sd_bus *bus, const char *path) {
         r = hashmap_put(bus->nodes, n->path, n);
         if (r < 0) {
                 free(n->path);
-                free(n);
-                return NULL;
+                return mfree(n);
         }
 
         if (parent)
index 5edb0bea7e0014c14b72486d928043c578236e74..d2665278c1ff3d305758bedd22c530315a7f7fb3 100644 (file)
@@ -113,8 +113,7 @@ _public_ struct udev_hwdb *udev_hwdb_unref(struct udev_hwdb *hwdb) {
                 return NULL;
         sd_hwdb_unref(hwdb->hwdb);
         udev_list_cleanup(&hwdb->properties_list);
-        free(hwdb);
-        return NULL;
+        return mfree(hwdb);
 }
 
 /**
index 3c9f1f949670ece3b08f01d2a52d54f08e4d1618..ca14373e19116e9759e02db0d15d042b5a5357f2 100644 (file)
@@ -493,8 +493,7 @@ _public_ struct udev_monitor *udev_monitor_unref(struct udev_monitor *udev_monit
                 close(udev_monitor->sock);
         udev_list_cleanup(&udev_monitor->filter_subsystem_list);
         udev_list_cleanup(&udev_monitor->filter_tag_list);
-        free(udev_monitor);
-        return NULL;
+        return mfree(udev_monitor);
 }
 
 /**
index b1e41c086d29ee5783f1a8a9ce27a35d57471958..b941afb77397449a612b1a1ee1abbdb0449a622d 100644 (file)
@@ -115,8 +115,7 @@ _public_ struct udev_queue *udev_queue_unref(struct udev_queue *udev_queue)
 
         safe_close(udev_queue->fd);
 
-        free(udev_queue);
-        return NULL;
+        return mfree(udev_queue);
 }
 
 /**
index 475b94f9136e46b802d65f0fcb4cb8922ebe8196..64904c5ffaceb2a50b056d7ae0d53f8a1a743b46 100644 (file)
@@ -136,8 +136,7 @@ _public_ struct udev *udev_unref(struct udev *udev) {
         udev->refcount--;
         if (udev->refcount > 0)
                 return udev;
-        free(udev);
-        return NULL;
+        return mfree(udev);
 }
 
 /**
index 11555b474cec72a7ad4635f0f127df18407ee8a3..f1e914cb2df48cda70dd64d6d137df2d2044dfcb 100644 (file)
@@ -78,8 +78,7 @@ Condition* condition_new(ConditionType type, const char *parameter, bool trigger
 
         r = free_and_strdup(&c->parameter, parameter);
         if (r < 0) {
-                free(c);
-                return NULL;
+                return mfree(c);
         }
 
         return c;
index 08f1e98640f610ffd22bd066d3ffd5b4dd5112c6..75e3431f283ed12fe21a6a907ec678e93eabbfff 100644 (file)
@@ -648,8 +648,7 @@ DissectedImage* dissected_image_unref(DissectedImage *m) {
         strv_free(m->machine_info);
         strv_free(m->os_release);
 
-        free(m);
-        return NULL;
+        return mfree(m);
 }
 
 static int is_loop_device(const char *path) {
index 31c5789a2ee96aeed8904293a8c3a9de3e979e2b..097de690e5ba9fad0db53fac3d869da93bd6b60a 100644 (file)
@@ -152,9 +152,7 @@ LoopDevice* loop_device_unref(LoopDevice *d) {
         }
 
         free(d->node);
-        free(d);
-
-        return NULL;
+        return mfree(d);
 }
 
 void loop_device_relinquish(LoopDevice *d) {