]> git.ipfire.org Git - thirdparty/sqlalchemy/sqlalchemy.git/commitdiff
- the refactor of the visit_alias() method in Oracle revealed
authorMike Bayer <mike_mp@zzzcomputing.com>
Fri, 5 Dec 2014 00:45:14 +0000 (19:45 -0500)
committerMike Bayer <mike_mp@zzzcomputing.com>
Fri, 5 Dec 2014 00:45:14 +0000 (19:45 -0500)
that quoting should be applied in %(name)s under with_hint.

doc/build/changelog/changelog_10.rst
test/sql/test_compiler.py

index 32fe4daabc3754a088dcb7400713488ad72a9640..0256958b24169ad8ce753e830aa8a1966bff7e8c 100644 (file)
     series as well.  For changes that are specific to 1.0 with an emphasis
     on compatibility concerns, see :doc:`/changelog/migration_10`.
 
+    .. change::
+        :tags: bug, oracle
+
+        An alias name will be properly quoted when referred to using the
+        ``%(name)s`` token inside the :meth:`.Select.with_hint` method.
+        Previously, the Oracle backend hadn't implemented this quoting.
+
     .. change::
         :tags: feature, oracle
         :tickets: 3220
index 9e99a947b0ddc3b6bd3ade8e8e8ef6123c42c4ea..428fc898602bf66662efc7b6d01ed910328dc14d 100644 (file)
@@ -2440,7 +2440,7 @@ class SelectTest(fixtures.TestBase, AssertsCompiledSQL):
                 """SELECT /*+ "QuotedName" idx1 */ "QuotedName".col1 """
                 """FROM "QuotedName" WHERE "QuotedName".col1 > :col1_1"""),
             (s7, oracle_d,
-             """SELECT /*+ SomeName idx1 */ "SomeName".col1 FROM """
+             """SELECT /*+ "SomeName" idx1 */ "SomeName".col1 FROM """
              """"QuotedName" "SomeName" WHERE "SomeName".col1 > :col1_1"""),
         ]:
             self.assert_compile(