]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
gpio: regmap: fix memory leak of gpio_regmap structure
authorIoana Ciornei <ioana.ciornei@nxp.com>
Mon, 22 Sep 2025 14:24:21 +0000 (17:24 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 2 Oct 2025 11:48:33 +0000 (13:48 +0200)
[ Upstream commit 3bd44edd6c55828fd4e11cb0efce5b7160bfa2de ]

The gpio_regmap structure is leaked on the error path. Fix this by
jumping to the appropriate kfree instead of returning directly.

Fixes: db305161880a ("gpio: regmap: Allow ngpio to be read from the property")
Signed-off-by: Ioana Ciornei <ioana.ciornei@nxp.com>
Suggested-by: Michael Walle <mwalle@kernel.org>
Reviewed-by: Michael Walle <mwalle@kernel.org>
Link: https://lore.kernel.org/r/20250922142427.3310221-7-ioana.ciornei@nxp.com
Signed-off-by: Bartosz Golaszewski <bartosz.golaszewski@linaro.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/gpio/gpio-regmap.c

index 87c4225784cfae6da619abdc101ee5a42fa3d729..b3b84a404485eb5ff069269f1c626167d596852e 100644 (file)
@@ -274,7 +274,7 @@ struct gpio_regmap *gpio_regmap_register(const struct gpio_regmap_config *config
        if (!chip->ngpio) {
                ret = gpiochip_get_ngpios(chip, chip->parent);
                if (ret)
-                       return ERR_PTR(ret);
+                       goto err_free_gpio;
        }
 
        /* if not set, assume there is only one register */