hs: Avoid possible double circuit close on error

Fixes #23610

Signed-off-by: David Goulet <dgoulet@torproject.org>

diff --git a/changes/bug23610 b/changes/bug23610
new file mode 100644 (file)
index 0000000..3d86852
--- /dev/null
+++ b/changes/bug23610
@@ -0,0 +1,4 @@
+  o Minor bugfixes (hidden service, relay):
+    - Avoid a possible double close of a circuit by the intro point on error
+      of sending the INTRO_ESTABLISHED cell. Fixes ticket 23610.; bugfix on
+      0.3.2.1-alpha.

diff --git a/src/or/hs_intropoint.c b/src/or/hs_intropoint.c
index cb4d6c02e5c6b474f2a05dbb0b42ec208d0a17ff..4a5202f6142e1dd6170815095188482438b00343 100644 (file)
--- a/src/or/hs_intropoint.c
+++ b/src/or/hs_intropoint.c
@@ -255,7 +255,11 @@ handle_establish_intro(or_circuit_t *circ, const uint8_t *request,
   goto done;
 
  err:
-  circuit_mark_for_close(TO_CIRCUIT(circ), END_CIRC_REASON_TORPROTOCOL);
+  /* When sending the intro establish ack, on error the circuit can be marked
+   * as closed so avoid a double close. */
+  if (!TO_CIRCUIT(circ)->marked_for_close) {
+    circuit_mark_for_close(TO_CIRCUIT(circ), END_CIRC_REASON_TORPROTOCOL);
+  }
 
  done:
   trn_cell_establish_intro_free(parsed_cell);