]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
wifi: mac80211: reset FILS discovery and unsol probe resp intervals
authorAloka Dixit <aloka.dixit@oss.qualcomm.com>
Wed, 24 Sep 2025 13:00:14 +0000 (18:30 +0530)
committerJohannes Berg <johannes.berg@intel.com>
Mon, 20 Oct 2025 11:53:06 +0000 (13:53 +0200)
When ieee80211_stop_ap() deletes the FILS discovery and unsolicited
broadcast probe response templates, the associated interval values
are not reset. This can lead to drivers subsequently operating with
the non-zero values, leading to unexpected behavior.

Trigger repeated retrieval attempts of the FILS discovery template in
ath12k, resulting in excessive log messages such as:

mac vdev 0 failed to retrieve FILS discovery template
mac vdev 4 failed to retrieve FILS discovery template

Fix this by resetting the intervals in ieee80211_stop_ap() to ensure
proper cleanup of FILS discovery and unsolicited broadcast probe
response templates.

Fixes: 295b02c4be74 ("mac80211: Add FILS discovery support")
Fixes: 632189a0180f ("mac80211: Unsolicited broadcast probe response support")
Signed-off-by: Aloka Dixit <aloka.dixit@oss.qualcomm.com>
Signed-off-by: Aaradhana Sahu <aaradhana.sahu@oss.qualcomm.com>
Link: https://patch.msgid.link/20250924130014.2575533-1-aaradhana.sahu@oss.qualcomm.com
Signed-off-by: Johannes Berg <johannes.berg@intel.com>
net/mac80211/cfg.c

index d9aca1c3c097eb13dc2e5a5c179bf83c35ad202b..c52b0456039ddcf460ecfbe91c98c5897eb975df 100644 (file)
@@ -1876,6 +1876,9 @@ static int ieee80211_stop_ap(struct wiphy *wiphy, struct net_device *dev,
        link_conf->nontransmitted = false;
        link_conf->ema_ap = false;
        link_conf->bssid_indicator = 0;
+       link_conf->fils_discovery.min_interval = 0;
+       link_conf->fils_discovery.max_interval = 0;
+       link_conf->unsol_bcast_probe_resp_interval = 0;
 
        __sta_info_flush(sdata, true, link_id, NULL);