Use consistent logic for checking to see if a call number has been chosen yet.

Also, remove some redundant logic I recently added in a fix.

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@114673 65c4cc65-6c06-0410-ace0-fbb531ad65f3

diff --git a/channels/chan_iax2.c b/channels/chan_iax2.c
index d44163e22694408c6c70337f44e616e5e2eee8b6..a949a1c50cf77555d246b174671369bfe215849e 100644 (file)
--- a/channels/chan_iax2.c
+++ b/channels/chan_iax2.c
@@ -1345,7 +1345,7 @@ static int __find_callno(unsigned short callno, unsigned short dcallno, struct s
 
        if (new <= NEW_ALLOW) {
                /* Look for an existing connection first */
-               for (x=1;(res < 1) && (x<maxnontrunkcall);x++) {
+               for (x = 1; !res && x < maxnontrunkcall; x++) {
                        ast_mutex_lock(&iaxsl[x]);
                        if (iaxs[x]) {
                                /* Look for an exact match */
@@ -1353,10 +1353,10 @@ static int __find_callno(unsigned short callno, unsigned short dcallno, struct s
                                        res = x;
                                }
                        }
-                       if (!res || (res && !return_locked))
+                       if (!res || !return_locked)
                                ast_mutex_unlock(&iaxsl[x]);
                }
-               for (x=TRUNK_CALL_START;(res < 1) && (x<maxtrunkcall);x++) {
+               for (x = TRUNK_CALL_START; !res && x < maxtrunkcall; x++) {
                        ast_mutex_lock(&iaxsl[x]);
                        if (iaxs[x]) {
                                /* Look for an exact match */
@@ -1364,11 +1364,11 @@ static int __find_callno(unsigned short callno, unsigned short dcallno, struct s
                                        res = x;
                                }
                        }
-                       if (!res || (res && !return_locked))
+                       if (!res || !return_locked)
                                ast_mutex_unlock(&iaxsl[x]);
                }
        }
-       if ((res < 1) && (new >= NEW_ALLOW)) {
+       if (!res && (new >= NEW_ALLOW)) {
                int start, found = 0;
 
                /* It may seem odd that we look through the peer list for a name for