]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
battery-check: parse options before checking for kernel command line
authorLuca Boccassi <luca.boccassi@gmail.com>
Fri, 8 Nov 2024 12:23:37 +0000 (12:23 +0000)
committerLuca Boccassi <luca.boccassi@gmail.com>
Thu, 12 Dec 2024 23:11:29 +0000 (23:11 +0000)
Otherwise --help/--version/etc which exit immediately will do pointless work

src/battery-check/battery-check.c

index 1563147b7b673c101c33121e4b8ddd2521bdf23a..a2ed5cbafd15d555a8ea40b7f16dd67b81aa389e 100644 (file)
@@ -123,14 +123,14 @@ static int run(int argc, char *argv[]) {
 
         log_setup();
 
-        r = proc_cmdline_get_bool("systemd.battery_check", PROC_CMDLINE_STRIP_RD_PREFIX|PROC_CMDLINE_TRUE_WHEN_MISSING, &arg_doit);
-        if (r < 0)
-                log_warning_errno(r, "Failed to parse systemd.battery_check= kernel command line option, ignoring: %m");
-
         r = parse_argv(argc, argv);
         if (r <= 0)
                 return r;
 
+        r = proc_cmdline_get_bool("systemd.battery_check", PROC_CMDLINE_STRIP_RD_PREFIX|PROC_CMDLINE_TRUE_WHEN_MISSING, &arg_doit);
+        if (r < 0)
+                log_warning_errno(r, "Failed to parse systemd.battery_check= kernel command line option, ignoring: %m");
+
         if (!arg_doit) {
                 log_info("Checking battery status and AC power existence is disabled by the kernel command line, skipping execution.");
                 return 0;