]> git.ipfire.org Git - thirdparty/u-boot.git/commitdiff
board: rockchip: Fix RG353M model renaming
authorDavid Barbion <davidb@230ruedubac.fr>
Wed, 10 Sep 2025 21:18:55 +0000 (23:18 +0200)
committerTom Rini <trini@konsulko.com>
Sun, 2 Nov 2025 18:15:23 +0000 (12:15 -0600)
Anbernic RG353M is hardware compatible with RG353P. Only the form-factor
differs. So only one DTS is created for both machines with
"Anbernic RG353P" as default model. If a RG353M is detected, the model
should be overwritten with the correct name.
Actually, it's overwritten with "Anbernic" only making the process of
machine detection a little harder.
However, to determine the size of the string "Anbernic RG353M", it is
sizeof() which is used resulting in obtaining the size of the pointer
(which is 8 bytes on ARM64) not the size of the pointed string.
strlen() should be used instead.

Signed-off-by: David Barbion <davidb@230ruedubac.fr>
Reviewed-by: Kever Yang <kever.yang@rock-chips.com>
board/anbernic/rgxx3_rk3566/rgxx3-rk3566.c

index c1d1826fd142c5b2d307d3a57fec3851fa6fd907..d402374e90e936a3006fc6a46db32c67f274cb2c 100644 (file)
@@ -695,7 +695,7 @@ int ft_board_setup(void *blob, struct bd_info *bd)
        if (gd->board_type == RG353M)
                fdt_setprop(blob, 0, "model",
                            rg3xx_model_details[RG353M].board_name,
-                           sizeof(rg3xx_model_details[RG353M].board_name));
+                           strlen(rg3xx_model_details[RG353M].board_name));
 
        if (rg3xx_model_details[gd->board_type].detect_panel) {
                ret = rgxx3_panel_fixup(blob);