]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
net-sysfs: remove rcu field from 'struct rps_sock_flow_table'
authorEric Dumazet <edumazet@google.com>
Mon, 2 Mar 2026 18:14:27 +0000 (18:14 +0000)
committerJakub Kicinski <kuba@kernel.org>
Thu, 5 Mar 2026 00:54:09 +0000 (16:54 -0800)
Removing rcu_head (and @mask in a following patch)
will allow a power-of-two allocation and thus high-order
allocation for better performance.

Signed-off-by: Eric Dumazet <edumazet@google.com>
Reviewed-by: Kuniyuki Iwashima <kuniyu@google.com>
Link: https://patch.msgid.link/20260302181432.1836150-3-edumazet@google.com
Signed-off-by: Jakub Kicinski <kuba@kernel.org>
include/net/rps.h
net/core/sysctl_net_core.c

index f1794cd2e7fb32a36bde9959fab651663ab190fd..32cfa250d9f931b8ab1c94e0410d0820bb9c999f 100644 (file)
@@ -60,7 +60,6 @@ struct rps_dev_flow_table {
  * meaning we use 32-6=26 bits for the hash.
  */
 struct rps_sock_flow_table {
-       struct rcu_head rcu;
        u32             mask;
 
        u32             ents[] ____cacheline_aligned_in_smp;
index 03aea10073f003b0339884ee0f40b8c96d7d22e2..0b659c932cffef45e05207890b8187d64ae3c85a 100644 (file)
@@ -147,6 +147,7 @@ static int rps_sock_flow_sysctl(const struct ctl_table *table, int write,
        };
        struct rps_sock_flow_table *orig_sock_table, *sock_table;
        static DEFINE_MUTEX(sock_flow_mutex);
+       void *tofree = NULL;
 
        mutex_lock(&sock_flow_mutex);
 
@@ -193,13 +194,14 @@ static int rps_sock_flow_sysctl(const struct ctl_table *table, int write,
                        if (orig_sock_table) {
                                static_branch_dec(&rps_needed);
                                static_branch_dec(&rfs_needed);
-                               kvfree_rcu(orig_sock_table, rcu);
+                               tofree = orig_sock_table;
                        }
                }
        }
 
        mutex_unlock(&sock_flow_mutex);
 
+       kvfree_rcu_mightsleep(tofree);
        return ret;
 }
 #endif /* CONFIG_RPS */