]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
gh-105587: Remove assertion from `_PyStaticObject_CheckRefcnt` (#105638)
authorEddie Elizondo <eduardo.elizondorueda@gmail.com>
Wed, 14 Jun 2023 04:33:32 +0000 (00:33 -0400)
committerGitHub <noreply@github.com>
Wed, 14 Jun 2023 04:33:32 +0000 (10:03 +0530)
Include/internal/pycore_global_objects_fini_generated.h
Misc/NEWS.d/next/Core and Builtins/2023-06-10-21-38-49.gh-issue-105587.rL3rzv.rst [new file with mode: 0644]

index 546ba6d4c5520ff987bea27c5df39f68195b6c8e..4b832164766424887660e9ca65373b42ef38a8e9 100644 (file)
@@ -12,9 +12,8 @@ extern "C" {
 static inline void
 _PyStaticObject_CheckRefcnt(PyObject *obj) {
     if (Py_REFCNT(obj) < _Py_IMMORTAL_REFCNT) {
-        _PyObject_ASSERT_FAILED_MSG(obj,
-            "immortal object has less refcnt than expected "
-            "_Py_IMMORTAL_REFCNT");
+        fprintf(stderr, "Immortal Object has less refcnt than expected.\n");
+        _PyObject_Dump(obj);
     }
 }
 #endif
diff --git a/Misc/NEWS.d/next/Core and Builtins/2023-06-10-21-38-49.gh-issue-105587.rL3rzv.rst b/Misc/NEWS.d/next/Core and Builtins/2023-06-10-21-38-49.gh-issue-105587.rL3rzv.rst
new file mode 100644 (file)
index 0000000..488f82c
--- /dev/null
@@ -0,0 +1,3 @@
+The runtime can't guarantee that immortal objects will not be mutated by
+Extensions. Thus, this modifies _PyStaticObject_CheckRefcnt to warn
+instead of asserting.