oauth_validator: Print captured stderr after call-count failure

If the call count test fails, you'll reasonably want to know what the
network trace looked like, but that information is currently swallowed.
Print it out instead.

Backpatch-through: 18

diff --git a/src/test/modules/oauth_validator/t/001_server.pl b/src/test/modules/oauth_validator/t/001_server.pl
index 1619fbffd458a6aef2046458968dd621f1ec2088..0d7618a5ef1cd81bd8194af841791ae6578dac83 100644 (file)
--- a/src/test/modules/oauth_validator/t/001_server.pl
+++ b/src/test/modules/oauth_validator/t/001_server.pl
@@ -518,7 +518,10 @@ if (like($stderr, $count_pattern, "call count: count is printed"))
        # to change across OSes and Curl updates, we're likely in trouble if we see
        # hundreds or thousands of calls.
        $stderr =~ $count_pattern;
-       cmp_ok($1, '<', 100, "call count is reasonably small");
+       unless (cmp_ok($1, '<', 100, "call count is reasonably small"))
+       {
+               diag "full stderr:\n$stderr";
+       }
 }
 
 # Stress test: make sure our builtin flow operates correctly even if the client