formatting.c cleanup: Use array syntax instead of pointer arithmetic

for easier readability

Reviewed-by: Chao Li <li.evan.chao@gmail.com>
Discussion: https://www.postgresql.org/message-id/flat/6dd9d208-a3ed-49b5-b03d-8617261da973%40eisentraut.org

diff --git a/src/backend/utils/adt/formatting.c b/src/backend/utils/adt/formatting.c
index a94e00eaa0deda59b3ce569ea5c4e6077a3eede7..cda7b2cb37caa615c978482369493686a164df7e 100644 (file)
--- a/src/backend/utils/adt/formatting.c
+++ b/src/backend/utils/adt/formatting.c
@@ -1109,7 +1109,7 @@ index_seq_search(const char *str, const KeyWord *kw, const int *index)
        if (!KeyWord_INDEX_FILTER(*str))
                return NULL;
 
-       if ((poz = *(index + (*str - ' '))) > -1)
+       if ((poz = index[*str - ' ']) > -1)
        {
                const KeyWord *k = kw + poz;
 
@@ -1531,7 +1531,7 @@ get_th(const char *num, int type)
 
        Assert(len > 0);
 
-       last = *(num + (len - 1));
+       last = num[len - 1];
        if (!isdigit((unsigned char) last))
                ereport(ERROR,
                                (errcode(ERRCODE_INVALID_TEXT_REPRESENTATION),
@@ -4807,7 +4807,7 @@ static char *
 fill_str(char *str, int c, int max)
 {
        memset(str, c, max);
-       *(str + max) = '\0';
+       str[max] = '\0';
        return str;
 }