Mark what looks like a bug in in _gnutls_srp_pwd_read_entry()

Signed-off-by: Simon Josefsson <simon@josefsson.org>

diff --git a/lib/auth_srp_passwd.c b/lib/auth_srp_passwd.c
index 4475abb3e93d5f4feba2700966bc9f989fff434b..376effda97ac3ac75dacf91678ccbd504801a5e8 100644 (file)
--- a/lib/auth_srp_passwd.c
+++ b/lib/auth_srp_passwd.c
@@ -347,7 +347,8 @@ _gnutls_srp_pwd_read_entry (gnutls_session_t state, char *username,
              /* Keep the last index in memory, so we can retrieve fake parameters (g,n)
               * when the user does not exist.
               */
-             last_idx = idx;
+              /* XXX: last_idx will not be read as both if block branches return. */
+              last_idx = idx;
              if (pwd_read_conf (cred->password_conf_file, entry, idx) == 0)
                {
                  return 0;