]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
nvme: stop setting namespace gendisk device driver data
authorJohn Garry <john.g.garry@oracle.com>
Thu, 5 Feb 2026 17:11:15 +0000 (17:11 +0000)
committerKeith Busch <kbusch@kernel.org>
Fri, 6 Feb 2026 15:59:11 +0000 (07:59 -0800)
Since commit 1f4137e882c6 ("nvme: move passthrough logging attribute to
head"), we stopped using the namespace to hold the passthrough logging
enabled attribute. There is now nowhere now which looks up the gendisk dev
driver data, so stop setting it.

Incidentally, it would have been better to set this before adding the
disk.

Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: John Garry <john.g.garry@oracle.com>
Signed-off-by: Keith Busch <kbusch@kernel.org>
drivers/nvme/host/core.c

index c12986495e712feac229f9bf4aef7fbcecb0cb62..3a2126584a23691c07c43fb1a32ae848b3942209 100644 (file)
@@ -4181,13 +4181,6 @@ static void nvme_alloc_ns(struct nvme_ctrl *ctrl, struct nvme_ns_info *info)
        nvme_mpath_add_disk(ns, info->anagrpid);
        nvme_fault_inject_init(&ns->fault_inject, ns->disk->disk_name);
 
-       /*
-        * Set ns->disk->device->driver_data to ns so we can access
-        * ns->head->passthru_err_log_enabled in
-        * nvme_io_passthru_err_log_enabled_[store | show]().
-        */
-       dev_set_drvdata(disk_to_dev(ns->disk), ns);
-
        return;
 
  out_cleanup_ns_from_list: