]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
test-fd-util: skip test when lacking privileges to create a new namespace
authorLuca Boccassi <luca.boccassi@gmail.com>
Wed, 11 Dec 2024 12:01:18 +0000 (12:01 +0000)
committerLuca Boccassi <luca.boccassi@gmail.com>
Wed, 11 Dec 2024 13:42:11 +0000 (13:42 +0000)
To reproduce, as an unprivileged user start a docker container and build
and run the unit tests inside it:

$ docker run --rm -ti debian:bookworm bash
...
/* test_close_all_fds */
Successfully forked off '(caf-plain)' as PID 10496.
Skipping PR_SET_MM, as we don't have privileges.
(caf-plain) succeeded.
Failed to fork off '(caf-noproc)': Operation not permitted
Assertion 'r >= 0' failed at src/test/test-fd-util.c:392, function test_close_all_fds(). Aborting.

Partially fixes #35552

src/test/test-fd-util.c

index 20cf7b7627b395fceb4c4a841142f8471055b95b..5817d92725254d3d2b5f6bebfbdf79d8d435d5a1 100644 (file)
@@ -389,6 +389,8 @@ TEST(close_all_fds) {
                         test_close_all_fds_inner();
                 _exit(EXIT_SUCCESS);
         }
+        if (ERRNO_IS_NEG_PRIVILEGE(r))
+                return (void) log_tests_skipped("Lacking privileges for test in namespace with /proc/ overmounted");
         assert_se(r >= 0);
 
         if (!is_seccomp_available())