]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
accel/ivpu: Fix race condition when mapping dmabuf
authorWludzik, Jozef <jozef.wludzik@intel.com>
Tue, 14 Oct 2025 07:17:25 +0000 (09:17 +0200)
committerKarol Wachowski <karol.wachowski@linux.intel.com>
Wed, 15 Oct 2025 06:10:22 +0000 (08:10 +0200)
Fix a race that can occur when multiple jobs submit the same dmabuf.
This could cause the sg_table to be mapped twice, leading to undefined
behavior.

Fixes: e0c0891cd63b ("accel/ivpu: Rework bind/unbind of imported buffers")
Signed-off-by: Wludzik, Jozef <jozef.wludzik@intel.com>
Reviewed-by: Jeff Hugo <jeff.hugo@oss.qualcomm.com>
Signed-off-by: Karol Wachowski <karol.wachowski@linux.intel.com>
Link: https://lore.kernel.org/r/20251014071725.3047287-1-karol.wachowski@linux.intel.com
drivers/accel/ivpu/ivpu_gem.c

index e9830ad48d4b024a4066c974f3c8ba720605831f..e7277e02840ae0c133848c52133abcbe8d779ca0 100644 (file)
@@ -46,12 +46,13 @@ static inline void ivpu_bo_unlock(struct ivpu_bo *bo)
 
 static struct sg_table *ivpu_bo_map_attachment(struct ivpu_device *vdev, struct ivpu_bo *bo)
 {
-       struct sg_table *sgt = bo->base.sgt;
+       struct sg_table *sgt;
 
        drm_WARN_ON(&vdev->drm, !bo->base.base.import_attach);
 
        ivpu_bo_lock(bo);
 
+       sgt = bo->base.sgt;
        if (!sgt) {
                sgt = dma_buf_map_attachment(bo->base.base.import_attach, DMA_BIDIRECTIONAL);
                if (IS_ERR(sgt))