]> git.ipfire.org Git - thirdparty/patchwork.git/commitdiff
requirements: Test older versions of DRF (v2)
authorStephen Finucane <stephen@that.guru>
Tue, 4 Apr 2017 21:38:19 +0000 (22:38 +0100)
committerStephen Finucane <stephen@that.guru>
Fri, 28 Apr 2017 21:20:44 +0000 (22:20 +0100)
In commit febad055, we attempted to start testing older versions of
Django REST Framework for use with older versions of Django. This work
was later reverted in commit 6f2ddab6 due to issues with 'django-filter'
versions.

There are additional reasons for validating older versions of DRF, such
as supporting the versions provide as part of distributions. It turns
out that those issues aren't such a big deal and can be handled with a
shim. All in all, this means we can and should support these older
versions of Django REST Framework, and that is what we'll do.

Note that the minimum version supported in requirements.txt is not
changed as it's good practice to use the latest available version.
However, that doesn't make it any less supported.

Signed-off-by: Stephen Finucane <stephen@that.guru>
README.rst
patchwork/settings/dev.py
tox.ini

index 79c83705c97acd93a3705c8733888b6cf7b64c68..36515737cdc0c630157a4543c230c856a4541fa5 100644 (file)
@@ -38,6 +38,17 @@ subsystems of the Linux kernel. Although Patchwork has been developed with the
 kernel workflow in mind, the aim is to be flexible enough to suit the majority
 of community projects.
 
+Requirements
+------------
+
+- Python (2.7, 3.3 - 3.5)
+
+- Django (1.6 - 1.10)
+
+- Django REST Framework (3.2 - 3.6)
+
+- Django Filters (0.11 - 1.0)
+
 Development Installation
 ------------------------
 
index ee5b203d6e801492f5740bc0cc44fd45cd8d5128..86b0f1b2580bb40bc67d34bfc8816fdd8bee5b78 100644 (file)
@@ -92,5 +92,4 @@ if django.VERSION >= (1, 8):
 
 ENABLE_XMLRPC = True
 
-if django.VERSION >= (1, 8):
-    ENABLE_REST_API = True
+ENABLE_REST_API = True
diff --git a/tox.ini b/tox.ini
index f1b892c91e7cd7ba5d4b3354313203f813447441..3da222c20ef49480e0a0e1279ed891bad201a28a 100644 (file)
--- a/tox.ini
+++ b/tox.ini
@@ -7,7 +7,11 @@ skipsdist = True
 deps =
     -r{toxinidir}/requirements-test.txt
     django16: django>=1.6,<1.7
+    django16: djangorestframework>=3.2,<3.3
+    django16: django-filter>=0.11,<0.12
     django17: django>=1.7,<1.8
+    django17: djangorestframework>=3.3,<3.4
+    django17: django-filter>=0.11,<0.12
     django18: django>=1.8,<1.9
     django19: django>=1.9,<1.10
     django110: django>=1.10,<1.11