nfq: clear memory of queue before using it

Avoids using uninitialized memory. Show showed itself
in nonsense values in counters, and in nfq_handle_packet
errors that were likely the result of passing uninitialized
memory to the nfq API.

Bug 3263.
Bug 3120.

Fixes: b2a6c60dee83 ("source-nfq: increase maximum queues number to 65535")

diff --git a/src/source-nfq.c b/src/source-nfq.c
index e820e71fe66977d31ef48eaa423b6b0a1d06f376..a0cab39b5e19c4eb7698a53f3c156f1adbdb005a 100644 (file)
--- a/src/source-nfq.c
+++ b/src/source-nfq.c
@@ -847,6 +847,7 @@ int NFQRegisterQueue(const uint16_t number)
     ntv->nfq_index = receive_queue_num;
 
     nq = &g_nfq_q[receive_queue_num];
+    memset(nq, 0, sizeof(*nq));
     nq->queue_num = number;
     receive_queue_num++;
     SCMutexUnlock(&nfq_init_lock);