tests: modify enter_cgroup_subroot() to return the new path

diff --git a/src/shared/tests.c b/src/shared/tests.c
index a4ffd3ec024e41447d1000023cf00df6e1ddc497..96b5b805a9678e514383924a4ef113a3d6f9da96 100644 (file)
--- a/src/shared/tests.c
+++ b/src/shared/tests.c
@@ -172,7 +172,7 @@ bool can_memlock(void) {
         return b;
 }
 
-int enter_cgroup_subroot(void) {
+int enter_cgroup_subroot(char **ret_cgroup) {
         _cleanup_free_ char *cgroup_root = NULL, *cgroup_subroot = NULL;
         CGroupMask supported;
         int r;
@@ -192,5 +192,11 @@ int enter_cgroup_subroot(void) {
         if (r < 0)
                 return r;
 
-        return cg_attach_everywhere(supported, cgroup_subroot, 0, NULL, NULL);
+        r = cg_attach_everywhere(supported, cgroup_subroot, 0, NULL, NULL);
+        if (r < 0)
+                return r;
+
+        if (ret_cgroup)
+                *ret_cgroup = TAKE_PTR(cgroup_subroot);
+        return 0;
 }

diff --git a/src/shared/tests.h b/src/shared/tests.h
index 3e4368460dda22e6d1b1fe8bb27767fa6e791f1a..5a6fd53f36b978f5725e5177d7a2b8acda65e3c1 100644 (file)
--- a/src/shared/tests.h
+++ b/src/shared/tests.h
@@ -19,7 +19,7 @@ static inline bool manager_errno_skip_test(int r) {
 }
 
 char* setup_fake_runtime_dir(void);
-int enter_cgroup_subroot(void);
+int enter_cgroup_subroot(char **ret_cgroup);
 const char* get_testdata_dir(void);
 const char* get_catalog_dir(void);
 bool slow_tests_enabled(void);

diff --git a/src/test/test-bpf-firewall.c b/src/test/test-bpf-firewall.c
index 13f81d48d05efbd9e0d5a0901e470a9d70ca53b5..31e0c0b916b8dd26d91a9833da2be3dc5c71fbb6 100644 (file)
--- a/src/test/test-bpf-firewall.c
+++ b/src/test/test-bpf-firewall.c
@@ -44,7 +44,7 @@ int main(int argc, char *argv[]) {
         if (!can_memlock())
                 return log_tests_skipped("Can't use mlock(), skipping.");
 
-        r = enter_cgroup_subroot();
+        r = enter_cgroup_subroot(NULL);
         if (r == -ENOMEDIUM)
                 return log_tests_skipped("cgroupfs not available");
 

diff --git a/src/test/test-cgroup-mask.c b/src/test/test-cgroup-mask.c
index 28a372125542adb2864ad9293361cafaa470fa1f..7fad58f690e3f6498088ba4e173ca1cb6668d207 100644 (file)
--- a/src/test/test-cgroup-mask.c
+++ b/src/test/test-cgroup-mask.c
@@ -33,7 +33,7 @@ static int test_cgroup_mask(void) {
         int r;
         CGroupMask cpu_accounting_mask = get_cpu_accounting_mask();
 
-        r = enter_cgroup_subroot();
+        r = enter_cgroup_subroot(NULL);
         if (r == -ENOMEDIUM)
                 return log_tests_skipped("cgroupfs not available");
 

diff --git a/src/test/test-cgroup-unit-default.c b/src/test/test-cgroup-unit-default.c
index c4af2a3cdfd1f047a94903612b465d99edfc3eba..1286f11e4eb35b4af2a48cfcac6c178f27cd2786 100644 (file)
--- a/src/test/test-cgroup-unit-default.c
+++ b/src/test/test-cgroup-unit-default.c
@@ -18,7 +18,7 @@ static int test_default_memory_low(void) {
         uint64_t dml_tree_default;
         int r;
 
-        r = enter_cgroup_subroot();
+        r = enter_cgroup_subroot(NULL);
         if (r == -ENOMEDIUM)
                 return log_tests_skipped("cgroupfs not available");
 

diff --git a/src/test/test-engine.c b/src/test/test-engine.c
index a32e98af119d325720e6719a33a4590041645ced..b8351141fe2afc1a8719435ccc2d4026cdfa32b9 100644 (file)
--- a/src/test/test-engine.c
+++ b/src/test/test-engine.c
@@ -21,7 +21,7 @@ int main(int argc, char *argv[]) {
 
         test_setup_logging(LOG_DEBUG);
 
-        r = enter_cgroup_subroot();
+        r = enter_cgroup_subroot(NULL);
         if (r == -ENOMEDIUM)
                 return log_tests_skipped("cgroupfs not available");
 

diff --git a/src/test/test-execute.c b/src/test/test-execute.c
index d84641475024687444ef20a596851dc06be24a9f..9d6aeed776fe33ed5a45f5d059880304b638c549 100644 (file)
--- a/src/test/test-execute.c
+++ b/src/test/test-execute.c
@@ -869,7 +869,7 @@ int main(int argc, char *argv[]) {
         if (getuid() != 0)
                 return log_tests_skipped("not root");
 
-        r = enter_cgroup_subroot();
+        r = enter_cgroup_subroot(NULL);
         if (r == -ENOMEDIUM)
                 return log_tests_skipped("cgroupfs not available");
 

diff --git a/src/test/test-load-fragment.c b/src/test/test-load-fragment.c
index 8127afdd766cf79e1eac6902cfeb03a9687967f6..8d0a4ad2e2c9ed7837f6f2f4b8b5954d93e9ba58 100644 (file)
--- a/src/test/test-load-fragment.c
+++ b/src/test/test-load-fragment.c
@@ -779,7 +779,7 @@ int main(int argc, char *argv[]) {
 
         test_setup_logging(LOG_INFO);
 
-        r = enter_cgroup_subroot();
+        r = enter_cgroup_subroot(NULL);
         if (r == -ENOMEDIUM)
                 return log_tests_skipped("cgroupfs not available");
 

diff --git a/src/test/test-path.c b/src/test/test-path.c
index 2537dc69720521caa9a89c6bb07260b0d714bb89..6ad222b5f928d60cac1303ed78d199aeea695055 100644 (file)
--- a/src/test/test-path.c
+++ b/src/test/test-path.c
@@ -31,7 +31,7 @@ static int setup_test(Manager **m) {
 
         assert_se(m);
 
-        r = enter_cgroup_subroot();
+        r = enter_cgroup_subroot(NULL);
         if (r == -ENOMEDIUM)
                 return log_tests_skipped("cgroupfs not available");
 

diff --git a/src/test/test-sched-prio.c b/src/test/test-sched-prio.c
index 386cd93cbf1ee15ab93274e1f57f41f22d5dbeb1..cd4553784734f7cc0dca01089df7b31905887e13 100644 (file)
--- a/src/test/test-sched-prio.c
+++ b/src/test/test-sched-prio.c
@@ -20,7 +20,7 @@ int main(int argc, char *argv[]) {
 
         test_setup_logging(LOG_INFO);
 
-        r = enter_cgroup_subroot();
+        r = enter_cgroup_subroot(NULL);
         if (r == -ENOMEDIUM)
                 return log_tests_skipped("cgroupfs not available");
 

diff --git a/src/test/test-unit-name.c b/src/test/test-unit-name.c
index d63647bad2c6b40bbed4cf61e479823c42d39c4d..38e37dacb2b64e84533a659a7cd4a21ee028f2a0 100644 (file)
--- a/src/test/test-unit-name.c
+++ b/src/test/test-unit-name.c
@@ -820,7 +820,7 @@ int main(int argc, char* argv[]) {
 
         test_setup_logging(LOG_INFO);
 
-        r = enter_cgroup_subroot();
+        r = enter_cgroup_subroot(NULL);
         if (r == -ENOMEDIUM)
                 return log_tests_skipped("cgroupfs not available");
 

diff --git a/src/test/test-watch-pid.c b/src/test/test-watch-pid.c
index a26a0c9d9bb994aca7545fc9f50b1fee2d710182..bad289767d212b250ecc274ed2d2194e31e2ae4d 100644 (file)
--- a/src/test/test-watch-pid.c
+++ b/src/test/test-watch-pid.c
@@ -16,7 +16,7 @@ int main(int argc, char *argv[]) {
 
         if (getuid() != 0)
                 return log_tests_skipped("not root");
-        r = enter_cgroup_subroot();
+        r = enter_cgroup_subroot(NULL);
         if (r == -ENOMEDIUM)
                 return log_tests_skipped("cgroupfs not available");