]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
sd-bus: don't treat invalid user/machine as a programming error 30033/head
authorFrantisek Sumsal <frantisek@sumsal.cz>
Wed, 15 Nov 2023 12:56:50 +0000 (13:56 +0100)
committerFrantisek Sumsal <frantisek@sumsal.cz>
Wed, 15 Nov 2023 12:56:50 +0000 (13:56 +0100)
$ SYSTEMD_LOG_LEVEL=debug machinectl status --machine=@
Assertion 'r > 0' failed at src/libsystemd/sd-bus/sd-bus.c:1694, function sd_bus_open_system_machine(). Ignoring.

src/libsystemd/sd-bus/sd-bus.c

index ced4466aa6f57d7cd7114a79a225d2f667550018..4a0259f8bbd27fc3326e39c0b39dc9c78e4aa41f 100644 (file)
@@ -1698,8 +1698,8 @@ _public_ int sd_bus_open_system_machine(sd_bus **ret, const char *user_and_machi
         r = user_and_machine_valid(user_and_machine);
         if (r < 0)
                 return r;
-
-        assert_return(r > 0, -EINVAL);
+        if (r == 0)
+                return -EINVAL;
 
         r = sd_bus_new(&b);
         if (r < 0)
@@ -1734,8 +1734,8 @@ _public_ int sd_bus_open_user_machine(sd_bus **ret, const char *user_and_machine
         r = user_and_machine_valid(user_and_machine);
         if (r < 0)
                 return r;
-
-        assert_return(r > 0, -EINVAL);
+        if (r == 0)
+                return -EINVAL;
 
         r = sd_bus_new(&b);
         if (r < 0)