]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
RDMA/rxe: Fix missing kconfig dependency on CRYPTO
authorJulian Braha <julianbraha@gmail.com>
Fri, 19 Feb 2021 23:32:26 +0000 (18:32 -0500)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 11 Mar 2021 13:05:00 +0000 (14:05 +0100)
[ Upstream commit 475f23b8c66d2892ad6acbf90ed757cafab13de7 ]

When RDMA_RXE is enabled and CRYPTO is disabled, Kbuild gives the
following warning:

 WARNING: unmet direct dependencies detected for CRYPTO_CRC32
   Depends on [n]: CRYPTO [=n]
   Selected by [y]:
   - RDMA_RXE [=y] && (INFINIBAND_USER_ACCESS [=y] || !INFINIBAND_USER_ACCESS [=y]) && INET [=y] && PCI [=y] && INFINIBAND [=y] && INFINIBAND_VIRT_DMA [=y]

This is because RDMA_RXE selects CRYPTO_CRC32, without depending on or
selecting CRYPTO, despite that config option being subordinate to CRYPTO.

Fixes: cee2688e3cd6 ("IB/rxe: Offload CRC calculation when possible")
Signed-off-by: Julian Braha <julianbraha@gmail.com>
Link: https://lore.kernel.org/r/21525878.NYvzQUHefP@ubuntu-mate-laptop
Signed-off-by: Jason Gunthorpe <jgg@nvidia.com>
Signed-off-by: Sasha Levin <sashal@kernel.org>
drivers/infiniband/sw/rxe/Kconfig

index 67ae960ab523b87cec69cc27009f625959f1ca90..1fa19a77583eab176538cf59d470759e4050adbc 100644 (file)
@@ -3,6 +3,7 @@ config RDMA_RXE
        depends on INET && PCI && INFINIBAND
        depends on !64BIT || ARCH_DMA_ADDR_T_64BIT
        select NET_UDP_TUNNEL
+       select CRYPTO
        select CRYPTO_CRC32
        select DMA_VIRT_OPS
        ---help---