serial: ns16550: Fix return-type warning

Fix compiler warning:

drivers/serial/ns16550.c: In function ‘serial_in_dynamic’:
drivers/serial/ns16550.c:153:1: warning: control reaches end
    of non-void function [-Wreturn-type]
  153 | }
      | ^

Observed with gcc 15.2.1:

$ riscv64-unknown-linux-gnu-gcc --version
riscv64-unknown-linux-gnu-gcc (Gentoo 15.2.1_p20260214 p5) 15.2.1

Fixes: 62cbde4c4e46 ("serial: ns16550: Support run-time configuration")
Signed-off-by: Nikita Shubin <nikita.shubin@maquefel.me>
Reviewed-by: Tom Rini <trini@konsulko.com>

diff --git a/drivers/serial/ns16550.c b/drivers/serial/ns16550.c
index c885b46cf56fcaec955fc5c5fbcdb1c09470a29a..2f24f47badfd12ac459b369dd279e0c4a7fa5cab 100644 (file)
--- a/drivers/serial/ns16550.c
+++ b/drivers/serial/ns16550.c
@@ -137,9 +137,9 @@ static int serial_in_dynamic(struct ns16550_plat *plat, u8 *addr)
                }
        } else if (plat->flags & NS16550_FLAG_BE) {
                return readb(addr + (1 << plat->reg_shift) - 1);
-       } else {
-               return readb(addr);
        }
+
+       return readb(addr);
 }
 #else
 static inline void serial_out_dynamic(struct ns16550_plat *plat, u8 *addr,