testsuite: don't use assert_return() for empty testsuite

With follow-up commit we'll rework/remove the macro, where the new
version does not allow for providing the return value.

Swap it for a manual ERR, printing a more useful error message.

Signed-off-by: Emil Velikov <emil.l.velikov@gmail.com>
Link: https://github.com/kmod-project/kmod/pull/375
Signed-off-by: Lucas De Marchi <ldemarchi@kernel.org>

diff --git a/testsuite/testsuite.c b/testsuite/testsuite.c
index 9f96ef944002dcf6d057a48b5a592b07df19dce5..57184d1690817c1c1d8f8b63d04e612a7b54cdab 100644 (file)
--- a/testsuite/testsuite.c
+++ b/testsuite/testsuite.c
@@ -83,7 +83,10 @@ int test_init(const struct test *start, const struct test *stop, int argc,
        progname = argv[0];
 
        /* An empty testsuite is not likely intended */
-       assert_return(start != stop, -EINVAL);
+       if (start == stop) {
+               ERR("Empty testsuite found. Did the compiler toolchain discard them?\n");
+               return -EINVAL;
+       }
 
        for (;;) {
                int c, idx = 0;