]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
leds: lp8860: Return directly from lp8860_init
authorAndrew Davis <afd@ti.com>
Thu, 5 Mar 2026 20:37:03 +0000 (14:37 -0600)
committerLee Jones <lee@kernel.org>
Tue, 10 Mar 2026 09:23:07 +0000 (09:23 +0000)
No need to use goto to jump to a label that also just returns,
return directly in the if statements.

Signed-off-by: Andrew Davis <afd@ti.com>
Link: https://patch.msgid.link/20260305203706.841384-2-afd@ti.com
Signed-off-by: Lee Jones <lee@kernel.org>
drivers/leds/leds-lp8860.c

index 87d298b6be7d0339be4556a8fb218d8098b2a3f6..71dcd55f0808f2c52e7c323137ceee15a48025f5 100644 (file)
@@ -216,41 +216,38 @@ static int lp8860_init(struct lp8860_led *led)
 
        ret = lp8860_fault_check(led);
        if (ret)
-               goto out;
+               return ret;
 
        ret = regmap_read(led->regmap, LP8860_STATUS, &read_buf);
        if (ret)
-               goto out;
+               return ret;
 
        ret = lp8860_unlock_eeprom(led);
        if (ret) {
                dev_err(&led->client->dev, "Failed unlocking EEPROM\n");
-               goto out;
+               return ret;
        }
 
        reg_count = ARRAY_SIZE(lp8860_eeprom_disp_regs);
        ret = regmap_multi_reg_write(led->regmap, lp8860_eeprom_disp_regs, reg_count);
        if (ret) {
                dev_err(&led->client->dev, "Failed writing EEPROM\n");
-               goto out;
+               return ret;
        }
 
        ret = regmap_write(led->regmap, LP8860_EEPROM_UNLOCK, LP8860_LOCK_EEPROM);
        if (ret)
-               goto out;
+               return ret;
 
        ret = regmap_write(led->regmap,
                        LP8860_EEPROM_CNTRL,
                        LP8860_PROGRAM_EEPROM);
        if (ret) {
                dev_err(&led->client->dev, "Failed programming EEPROM\n");
-               goto out;
+               return ret;
        }
 
-       return ret;
-
-out:
-       return ret;
+       return 0;
 }
 
 static const struct regmap_range lp8860_reg_ranges[] = {