]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
remoteproc: imx_rproc: Fix NULL vs IS_ERR() bug in imx_rproc_addr_init()
authorChen Ni <nichen@iscas.ac.cn>
Fri, 27 Feb 2026 09:15:46 +0000 (17:15 +0800)
committerMathieu Poirier <mathieu.poirier@linaro.org>
Thu, 5 Mar 2026 17:22:05 +0000 (10:22 -0700)
The devm_ioremap_resource_wc() function never returns NULL, it returns
error pointers.  Update the error checking to match.

Fixes: 67a7bc7f0358 ("remoteproc: Use of_reserved_mem_region_* functions for "memory-region"")
Signed-off-by: Chen Ni <nichen@iscas.ac.cn>
Reviewed-by: Peng Fan <peng.fan@nxp.com>
Cc: stable@vger.kernel.org
Link: https://lore.kernel.org/r/20260227091546.4044246-1-nichen@iscas.ac.cn
Signed-off-by: Mathieu Poirier <mathieu.poirier@linaro.org>
drivers/remoteproc/imx_rproc.c

index 75baf905988b5b083a9525ff7f00d0f4eac367cd..ef8f7c8fbda8f8d22ceaa2acf6f50d1e7bf4ba7b 100644 (file)
@@ -812,7 +812,7 @@ static int imx_rproc_addr_init(struct imx_rproc *priv,
 
                /* Not use resource version, because we might share region */
                priv->mem[b].cpu_addr = devm_ioremap_resource_wc(&pdev->dev, &res);
-               if (!priv->mem[b].cpu_addr) {
+               if (IS_ERR(priv->mem[b].cpu_addr)) {
                        dev_err(dev, "failed to remap %pr\n", &res);
                        return -ENOMEM;
                }