s3:passdb: Fix 'return 1' in secrets_store_creds()

The recently introduced function secrets_store_creds() should always
use 'return false' in case of a failure. It is not only spelling issue
since 'return 1' actually means 'return true'.

Signed-off-by: Pavel Filipensky <pavel.filipensky@gmail.com>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>
Reviewed-by: Volker Lendecke <vl@samba.org>
Autobuild-User(master): Volker Lendecke <vl@samba.org>
Autobuild-Date(master): Tue Apr 20 06:42:50 UTC 2021 on sn-devel-184

diff --git a/source3/passdb/secrets.c b/source3/passdb/secrets.c
index be9cc0039d36d076012fca5cda054f1aef9d54f6..fdacafa11c97798062fe464f31015ef38a32e210 100644 (file)
--- a/source3/passdb/secrets.c
+++ b/source3/passdb/secrets.c
@@ -169,7 +169,7 @@ bool secrets_store_creds(struct cli_credentials *creds)
        ok = secrets_store(SECRETS_AUTH_DOMAIN, p, strlen(p) + 1);
        if (!ok) {
                DBG_ERR("Failed storing auth domain name\n");
-               return 1;
+               return false;
        }