]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
netfs: Prevent duplicate unlocking
authorLizhi Xu <lizhi.xu@windriver.com>
Fri, 5 Sep 2025 01:59:25 +0000 (09:59 +0800)
committerChristian Brauner <brauner@kernel.org>
Mon, 15 Sep 2025 11:57:15 +0000 (13:57 +0200)
The filio lock has been released here, so there is no need to jump to
error_folio_unlock to release it again.

Reported-by: syzbot+b73c7d94a151e2ee1e9b@syzkaller.appspotmail.com
Closes: https://syzkaller.appspot.com/bug?extid=b73c7d94a151e2ee1e9b
Signed-off-by: Lizhi Xu <lizhi.xu@windriver.com>
Acked-by: David Howells <dhowells@redhat.com>
Reviewed-by: Paulo Alcantara (Red Hat) <pc@manguebit.org>
Signed-off-by: Christian Brauner <brauner@kernel.org>
fs/netfs/buffered_write.c

index f27ea5099a6813002c793b542633b2504d881aad..09394ac2c180d312b209a25b2c629c23b1dee547 100644 (file)
@@ -347,7 +347,7 @@ ssize_t netfs_perform_write(struct kiocb *iocb, struct iov_iter *iter,
                folio_put(folio);
                ret = filemap_write_and_wait_range(mapping, fpos, fpos + flen - 1);
                if (ret < 0)
-                       goto error_folio_unlock;
+                       goto out;
                continue;
 
        copied: