Check for micro < 0, rather than checking "minor" twice.

Bug found with clang scan-build.  Fixes bug on f63e06d3dc6757d.
Bug not present in any released Tor.

diff --git a/src/or/routerparse.c b/src/or/routerparse.c
index 7d9769b49940960e9a18b93eab117c9c25a1eca0..2ee0d2720ee09916f6ef153182917b2c7e756479 100644 (file)
--- a/src/or/routerparse.c
+++ b/src/or/routerparse.c
@@ -5551,7 +5551,7 @@ tor_version_parse_platform(const char *platform,
   if (strict) {
     if (router_version->major < 0 ||
         router_version->minor < 0 ||
-        router_version->minor < 0 ||
+        router_version->micro < 0 ||
         router_version->patchlevel < 0 ||
         router_version->svn_revision < 0) {
       return -1;