Handle strlcat/strlcpy correctly on platforms that have them.

svn:r2647

diff --git a/configure.in b/configure.in
index 50d952dde3f31aa47ac1d957ef19244492348958..2b63da3d99aaaacc31141284e1f866284e7c9c00 100644 (file)
--- a/configure.in
+++ b/configure.in
@@ -143,8 +143,7 @@ dnl These headers are not essential
 
 AC_CHECK_HEADERS(stdint.h sys/types.h inttypes.h sys/param.h sys/wait.h sys/limits.h netinet/in.h arpa/inet.h machine/limits.h syslog.h sys/time.h sys/resource.h)
 
-AC_CHECK_FUNCS(gettimeofday ftime socketpair uname inet_aton strptime getrlimit setrlimit)
-AC_REPLACE_FUNCS(strlcat strlcpy)
+AC_CHECK_FUNCS(gettimeofday ftime socketpair uname inet_aton strptime getrlimit setrlimit strlcat strlcpy)
 
 AC_CHECK_MEMBERS([struct timeval.tv_sec])
 
@@ -233,10 +232,10 @@ AC_SUBST(LOCALSTATEDIR)
 
 # Set CFLAGS _after_ all the above checks, since our warnings are stricter
 # than autoconf's macros like.
-CFLAGS="$CFLAGS -Wall -W -Wno-unused-parameter -Wfloat-equal -Wdeclaration-after-statement -Wundef -Wendif-labels -Wpointer-arith -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wredundant-decls -g -O2"
+CFLAGS="$CFLAGS -Wall -W -Wno-unused-parameter -Wfloat-equal -Wundef -Wendif-labels -Wpointer-arith -Wwrite-strings -Wstrict-prototypes -Wmissing-prototypes -Wredundant-decls -g -O2"
 
 # Add these in when you feel like fun.
-# -Wbad-function-cast -Werror
+# -Wbad-function-cast -Werror  -Wdeclaration-after-statement
 
 echo "confdir: $CONFDIR"
 

diff --git a/src/common/compat.c b/src/common/compat.c
index 58ba52c37509f2eaeb63e6a4ceb9df256a190040..649d99e8fc661e454244c53d2bd123a9b92613b6 100644 (file)
--- a/src/common/compat.c
+++ b/src/common/compat.c
@@ -68,6 +68,14 @@
 #include "log.h"
 #include "util.h"
 
+/* Inline the strl functions if the plaform doesn't have them. */
+#ifndef HAVE_STRLCPY
+#include "strlcpy.c"
+#endif
+#ifndef HAVE_STRLCAT
+#include "strlcat.c"
+#endif
+
 /** Replacement for snprintf.  Differs from platform snprintf in two
  * ways: First, always NUL-terminates its output.  Second, always
  * returns -1 if the result is truncated.  (Note that this return

diff --git a/src/common/compat.h b/src/common/compat.h
index 50acd4244423a2f70733bc021e55fef375a68cc0..707a349f0b6968acba174883721ed13c693593f7 100644 (file)
--- a/src/common/compat.h
+++ b/src/common/compat.h
@@ -55,6 +55,12 @@
 #define strncasecmp strnicmp
 #define strcasecmp stricmp
 #endif
+#ifndef HAVE_STRLCAT
+size_t strlcat(char *dst, const char *src, size_t siz);
+#endif
+#ifndef HAVE_STRLCPY
+size_t strlcpy(char *dst, const char *src, size_t siz);
+#endif
 
 int tor_snprintf(char *str, size_t size, const char *format, ...)
      CHECK_PRINTF(3,4);

diff --git a/src/common/util.c b/src/common/util.c
index 60496d394066eaffef4630a7ded3e7687f52af97..ffe217c6969bb3d53cb2c1332d000f1cb9ad0785 100644 (file)
--- a/src/common/util.c
+++ b/src/common/util.c
@@ -88,14 +88,6 @@
 #define INADDR_NONE ((unsigned long) -1)
 #endif
 
-/* Inline the strl functions if the plaform doesn't have them. */
-#ifndef HAVE_STRLCPY
-#include "strlcpy.c"
-#endif
-#ifndef HAVE_STRLCAT
-#include "strlcat.c"
-#endif
-
 #ifndef O_BINARY
 #define O_BINARY 0
 #endif

diff --git a/src/common/util.h b/src/common/util.h
index 0fa51532d879c577ce1a0a72f652cbd40085f295..ae5ab9dc57ac3c33d9b5eb619825f6f7973b94bc 100644 (file)
--- a/src/common/util.h
+++ b/src/common/util.h
@@ -46,9 +46,6 @@ char *tor_strndup(const char *s, size_t n);
 
 /* String manipulation */
 #define HEX_CHARACTERS "0123456789ABCDEFabcdef"
-size_t strlcat(char *dst, const char *src, size_t siz);
-size_t strlcpy(char *dst, const char *src, size_t siz);
-
 void tor_strlower(char *s);
 int strcmpstart(const char *s1, const char *s2);
 int tor_strstrip(char *s, const char *strip);