]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
ASoC: pxa: fix a memory leak in probe()
authorDan Carpenter <dan.carpenter@linaro.org>
Thu, 5 Oct 2023 14:00:24 +0000 (17:00 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Wed, 25 Oct 2023 09:59:03 +0000 (11:59 +0200)
[ Upstream commit aa6464edbd51af4a2f8db43df866a7642b244b5f ]

Free the "priv" pointer before returning the error code.

Fixes: 90eb6b59d311 ("ASoC: pxa-ssp: add support for an external clock in devicetree")
Signed-off-by: Dan Carpenter <dan.carpenter@linaro.org>
Link: https://lore.kernel.org/r/84ac2313-1420-471a-b2cb-3269a2e12a7c@moroto.mountain
Signed-off-by: Mark Brown <broonie@kernel.org>
Signed-off-by: Sasha Levin <sashal@kernel.org>
sound/soc/pxa/pxa-ssp.c

index 7f13a35e9cc145342855c4286cf1059edfaa58a1..d6a2af293f458a8389a731d3ebbe3d2841a6b8ed 100644 (file)
@@ -779,7 +779,7 @@ static int pxa_ssp_probe(struct snd_soc_dai *dai)
                if (IS_ERR(priv->extclk)) {
                        ret = PTR_ERR(priv->extclk);
                        if (ret == -EPROBE_DEFER)
-                               return ret;
+                               goto err_priv;
 
                        priv->extclk = NULL;
                }