]> git.ipfire.org Git - thirdparty/kernel/linux.git/commitdiff
drm/solomon: Use drm_WARN_ON_ONCE instead of WARN_ON
authorIker Pedrosa <ikerpedrosam@gmail.com>
Sat, 20 Sep 2025 09:45:42 +0000 (11:45 +0200)
committerJavier Martinez Canillas <javierm@redhat.com>
Fri, 26 Sep 2025 13:04:45 +0000 (15:04 +0200)
To prevent log spam, convert all instances to the DRM-specific
drm_WARN_ON_ONCE() macro. This ensures that a warning is emitted only
the first time the condition is met for a given device instance, which
is the desired behavior within the graphics subsystem.

Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
Reviewed-by: Thomas Zimmermann <tzimmermann@suse.de>
Signed-off-by: Iker Pedrosa <ikerpedrosam@gmail.com>
Link: https://lore.kernel.org/r/20250920-improve-ssd130x-v2-2-77721e87ae08@gmail.com
Signed-off-by: Javier Martinez Canillas <javierm@redhat.com>
drivers/gpu/drm/solomon/ssd130x.c

index feaeadc49cce0536a66efc29e68bc5c733b47e12..09792be46f91e385a7813fb6e1d04ab392ec7435 100644 (file)
@@ -1393,7 +1393,7 @@ static void ssd130x_primary_plane_reset(struct drm_plane *plane)
 {
        struct ssd130x_plane_state *ssd130x_state;
 
-       WARN_ON(plane->state);
+       drm_WARN_ON_ONCE(plane->dev, plane->state);
 
        ssd130x_state = kzalloc(sizeof(*ssd130x_state), GFP_KERNEL);
        if (!ssd130x_state)
@@ -1408,7 +1408,7 @@ static struct drm_plane_state *ssd130x_primary_plane_duplicate_state(struct drm_
        struct ssd130x_plane_state *old_ssd130x_state;
        struct ssd130x_plane_state *ssd130x_state;
 
-       if (WARN_ON(!plane->state))
+       if (drm_WARN_ON_ONCE(plane->dev, !plane->state))
                return NULL;
 
        old_ssd130x_state = to_ssd130x_plane_state(plane->state);
@@ -1558,7 +1558,7 @@ static void ssd130x_crtc_reset(struct drm_crtc *crtc)
 {
        struct ssd130x_crtc_state *ssd130x_state;
 
-       WARN_ON(crtc->state);
+       drm_WARN_ON_ONCE(crtc->dev, crtc->state);
 
        ssd130x_state = kzalloc(sizeof(*ssd130x_state), GFP_KERNEL);
        if (!ssd130x_state)
@@ -1572,7 +1572,7 @@ static struct drm_crtc_state *ssd130x_crtc_duplicate_state(struct drm_crtc *crtc
        struct ssd130x_crtc_state *old_ssd130x_state;
        struct ssd130x_crtc_state *ssd130x_state;
 
-       if (WARN_ON(!crtc->state))
+       if (drm_WARN_ON_ONCE(crtc->dev, !crtc->state))
                return NULL;
 
        old_ssd130x_state = to_ssd130x_crtc_state(crtc->state);