]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
kconfig: return 'false' instead of 'no' in bool function
authorVegard Nossum <vegard.nossum@oracle.com>
Fri, 1 Jan 2016 16:34:05 +0000 (17:34 +0100)
committerLuis Henriques <luis.henriques@canonical.com>
Tue, 2 Feb 2016 19:46:40 +0000 (19:46 +0000)
commit aab24a897cfba9dd371f6aac45dbcdae0b23def6 upstream.

menu_is_visible() is a bool function and should use boolean return
values. "no" is a tristate value which happens to also have a value
of 0, but we should nevertheless use the right symbol for it.

This is a very minor cleanup with no semantic change.

Fixes: 86e187ff9 ("kconfig: add an option to determine a menu's visibility")
Cc: Arnaud Lacombe <lacombar@gmail.com>
Cc: Mauro Carvalho Chehab <mchehab@redhat.com>
Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
Signed-off-by: Michal Marek <mmarek@suse.com>
Signed-off-by: Luis Henriques <luis.henriques@canonical.com>
scripts/kconfig/menu.c

index 72c9dba84c5dbd46cb8ae2824a85d54603dbaafe..876c45d756d041ad34b7f59324fc3dfafc0decad 100644 (file)
@@ -477,7 +477,7 @@ bool menu_is_visible(struct menu *menu)
 
        if (menu->visibility) {
                if (expr_calc_value(menu->visibility) == no)
-                       return no;
+                       return false;
        }
 
        sym = menu->sym;