]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s3/lib/dwrap: clang: Fix 'Value stored to 'ret' is never read'
authorNoel Power <noel.power@suse.com>
Tue, 9 Jul 2019 14:13:13 +0000 (14:13 +0000)
committerGary Lockyer <gary@samba.org>
Wed, 24 Jul 2019 21:33:20 +0000 (21:33 +0000)
Fixes:

source3/lib/dbwrap/dbwrap_ctdb.c:95:2: warning: Value stored to 'ret' is never read <--[clang]
        ret = ctdbd_init_connection(mem_ctx,
        ^     ~~~~~~

Signed-off-by: Noel Power <noel.power@suse.com>
Reviewed-by: Gary Lockyer <gary@catalyst.net.nz>
source3/lib/dbwrap/dbwrap_ctdb.c

index b487d10bddbbf17bbcc1376cbab1dead62443380..33558e442f3b4bd4a7a193e276d565cae06dec55 100644 (file)
@@ -98,7 +98,7 @@ static int ctdb_async_ctx_init_internal(TALLOC_CTX *mem_ctx,
                                    &ctdb_async_ctx.async_conn);
        unbecome_root();
 
-       if (ctdb_async_ctx.async_conn == NULL) {
+       if (ret != 0 || ctdb_async_ctx.async_conn == NULL) {
                DBG_ERR("ctdbd_init_connection failed\n");
                return EIO;
        }