]> git.ipfire.org Git - thirdparty/tor.git/commitdiff
prop224: Add XXX about opaqueness of link_specifier_t.
authorGeorge Kadianakis <desnacked@riseup.net>
Tue, 8 Aug 2017 18:25:04 +0000 (21:25 +0300)
committerNick Mathewson <nickm@torproject.org>
Wed, 9 Aug 2017 00:29:35 +0000 (20:29 -0400)
src/trunnel/ed25519_cert.h

index 782bd595850dd0424771a7ff4611991827d62bad..0aa953d174a2bc866bf77efb1d6894f0fe81aae4 100644 (file)
@@ -59,6 +59,10 @@ struct link_specifier_st {
 };
 #endif
 typedef struct link_specifier_st link_specifier_t;
+/** XXX hs_link_specifier_dup() violates the opaqueness of link_specifier_t by
+ *  taking its sizeof(). If we ever want to turn on TRUNNEL_OPAQUE we would
+ *  need to refactor that function to do the coyp by encoding and decoding the
+ *  object. */
 #if !defined(TRUNNEL_OPAQUE) && !defined(TRUNNEL_OPAQUE_ED25519_CERT)
 struct ed25519_cert_st {
   uint8_t version;