hwmon: (adc128d818) Fix underflows seen when writing limit attributes

[ Upstream commit 8cad724c8537fe3e0da8004646abc00290adae40 ]

DIV_ROUND_CLOSEST() after kstrtol() results in an underflow if a large
negative number such as -9223372036854775808 is provided by the user.
Fix it by reordering clamp_val() and DIV_ROUND_CLOSEST() operations.

Signed-off-by: Guenter Roeck <linux@roeck-us.net>
Signed-off-by: Sasha Levin <sashal@kernel.org>

diff --git a/drivers/hwmon/adc128d818.c b/drivers/hwmon/adc128d818.c
index 46e3c8c507657366a9377e23d1f73fbb2b152ceb..73fd967998472c1fadd3f564887d55f2876b08f9 100644 (file)
--- a/drivers/hwmon/adc128d818.c
+++ b/drivers/hwmon/adc128d818.c
@@ -176,7 +176,7 @@ static ssize_t adc128_in_store(struct device *dev,
 
        mutex_lock(&data->update_lock);
        /* 10 mV LSB on limit registers */
-       regval = clamp_val(DIV_ROUND_CLOSEST(val, 10), 0, 255);
+       regval = DIV_ROUND_CLOSEST(clamp_val(val, 0, 2550), 10);
        data->in[index][nr] = regval << 4;
        reg = index == 1 ? ADC128_REG_IN_MIN(nr) : ADC128_REG_IN_MAX(nr);
        i2c_smbus_write_byte_data(data->client, reg, regval);
@@ -214,7 +214,7 @@ static ssize_t adc128_temp_store(struct device *dev,
                return err;
 
        mutex_lock(&data->update_lock);
-       regval = clamp_val(DIV_ROUND_CLOSEST(val, 1000), -128, 127);
+       regval = DIV_ROUND_CLOSEST(clamp_val(val, -128000, 127000), 1000);
        data->temp[index] = regval << 1;
        i2c_smbus_write_byte_data(data->client,
                                  index == 1 ? ADC128_REG_TEMP_MAX