]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
power: supply: max17042: fix OF node reference imbalance
authorJohan Hovold <johan@kernel.org>
Tue, 7 Apr 2026 12:33:38 +0000 (14:33 +0200)
committerSebastian Reichel <sebastian.reichel@collabora.com>
Wed, 3 Jun 2026 19:58:54 +0000 (21:58 +0200)
The driver reuses the OF node of the parent multi-function device but
fails to take another reference to balance the one dropped by the
platform bus code when unbinding the MFD and deregistering the child
devices.

Fix this by using the intended helper for reusing OF nodes.

Fixes: 0cd4f1f77ad4 ("power: supply: max17042: add platform driver variant")
Cc: stable@vger.kernel.org # 6.14
Cc: Dzmitry Sankouski <dsankouski@gmail.com>
Signed-off-by: Johan Hovold <johan@kernel.org>
Link: https://patch.msgid.link/20260407123338.2677375-1-johan@kernel.org
Signed-off-by: Sebastian Reichel <sebastian.reichel@collabora.com>
drivers/power/supply/max17042_battery.c

index abd276e13475c0087d7925a14d18440050bbf948..024fa38888f658208cbd632a66c2a2d76c67674c 100644 (file)
@@ -1288,7 +1288,8 @@ static int max17042_platform_probe(struct platform_device *pdev)
        if (!i2c)
                return -EINVAL;
 
-       dev->of_node = dev->parent->of_node;
+       device_set_of_node_from_dev(dev, dev->parent);
+
        id = platform_get_device_id(pdev);
        irq = platform_get_irq(pdev, 0);