]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
arm64: dts: qcom: msm8953: correct SPI pinctrls
authorBarnabás Czémán <barnabas.czeman@mainlining.org>
Sat, 30 Aug 2025 21:13:20 +0000 (23:13 +0200)
committerBjorn Andersson <andersson@kernel.org>
Mon, 1 Sep 2025 18:03:31 +0000 (13:03 -0500)
SPI pinctrls should handle 4 pins MOSI, MISO, CLK and CS.
This change adding the missing pins for pinctrls and correcting
CS pins according to downstream sources.

Fixes: be69109e93c78 ("arm64: dts: qcom: msm8953: add SPI interfaces")
Signed-off-by: Barnabás Czémán <barnabas.czeman@mainlining.org>
Link: https://lore.kernel.org/r/20250830-msm8953-spi-fix-v1-2-89950eaf10fe@mainlining.org
Signed-off-by: Bjorn Andersson <andersson@kernel.org>
arch/arm64/boot/dts/qcom/msm8953.dtsi

index 14dd17278ae0850df1dafad19a569ffc5afb174b..1b3e68aed9450f61d14fe6c16a4dd513c815c6da 100644 (file)
                        };
 
                        spi_3_default: spi-3-default-state {
-                               pins = "gpio10", "gpio11";
-                               function = "blsp_spi3";
-                               drive-strength = <2>;
-                               bias-disable;
+                               cs-pins {
+                                       pins = "gpio10";
+                                       function = "blsp_spi3";
+                                       drive-strength = <2>;
+                                       bias-disable;
+                               };
+
+                               spi-pins {
+                                       pins = "gpio8", "gpio9", "gpio11";
+                                       function = "blsp_spi3";
+                                       drive-strength = <12>;
+                                       bias-disable;
+                               };
                        };
 
                        spi_3_sleep: spi-3-sleep-state {
-                               pins = "gpio10", "gpio11";
-                               function = "gpio";
-                               drive-strength = <2>;
-                               bias-disable;
+                               cs-pins {
+                                       pins = "gpio10";
+                                       function = "gpio";
+                                       drive-strength = <2>;
+                                       bias-disable;
+                               };
+
+                               spi-pins {
+                                       pins = "gpio8", "gpio9", "gpio11";
+                                       function = "gpio";
+                                       drive-strength = <2>;
+                                       bias-pull-down;
+                               };
                        };
 
                        spi_5_default: spi-5-default-state {
-                               pins = "gpio18", "gpio19";
-                               function = "blsp_spi5";
-                               drive-strength = <2>;
-                               bias-disable;
+                               cs-pins {
+                                       pins = "gpio18";
+                                       function = "blsp_spi5";
+                                       drive-strength = <2>;
+                                       bias-disable;
+                               };
+
+                               spi-pins {
+                                       pins = "gpio16", "gpio17", "gpio19";
+                                       function = "blsp_spi5";
+                                       drive-strength = <12>;
+                                       bias-disable;
+                               };
                        };
 
                        spi_5_sleep: spi-5-sleep-state {
-                               pins = "gpio18", "gpio19";
-                               function = "gpio";
-                               drive-strength = <2>;
-                               bias-disable;
+                               cs-pins {
+                                       pins = "gpio18";
+                                       function = "gpio";
+                                       drive-strength = <2>;
+                                       bias-disable;
+                               };
+
+                               spi-pins {
+                                       pins = "gpio16", "gpio17", "gpio19";
+                                       function = "gpio";
+                                       drive-strength = <2>;
+                                       bias-pull-down;
+                               };
                        };
 
                        spi_6_default: spi-6-default-state {
-                               pins = "gpio22", "gpio23";
-                               function = "blsp_spi6";
-                               drive-strength = <2>;
-                               bias-disable;
+                               cs-pins {
+                                       pins = "gpio22";
+                                       function = "blsp_spi6";
+                                       drive-strength = <2>;
+                                       bias-disable;
+                               };
+
+                               spi-pins {
+                                       pins = "gpio20", "gpio21", "gpio23";
+                                       function = "blsp_spi6";
+                                       drive-strength = <12>;
+                                       bias-disable;
+                               };
                        };
 
                        spi_6_sleep: spi-6-sleep-state {
-                               pins = "gpio22", "gpio23";
-                               function = "gpio";
-                               drive-strength = <2>;
-                               bias-disable;
+                               cs-pins {
+                                       pins = "gpio22";
+                                       function = "gpio";
+                                       drive-strength = <2>;
+                                       bias-disable;
+                               };
+
+                               spi-pins {
+                                       pins = "gpio20", "gpio21", "gpio23";
+                                       function = "gpio";
+                                       drive-strength = <2>;
+                                       bias-pull-down;
+                               };
                        };
 
                        uart_5_default: uart-5-default-state {