]> git.ipfire.org Git - thirdparty/linux.git/commitdiff
spi: nxp-fspi: Remove error print for devm_add_action_or_reset()
authorWaqar Hameed <waqar.hameed@axis.com>
Tue, 5 Aug 2025 09:33:37 +0000 (11:33 +0200)
committerMark Brown <broonie@kernel.org>
Sun, 10 Aug 2025 20:11:38 +0000 (21:11 +0100)
When `devm_add_action_or_reset()` fails, it is due to a failed memory
allocation and will thus return `-ENOMEM`. `dev_err_probe()` doesn't do
anything when error is `-ENOMEM`. Therefore, remove the useless call to
`dev_err_probe()` when `devm_add_action_or_reset()` fails, and just
return the value instead.

Signed-off-by: Waqar Hameed <waqar.hameed@axis.com>
Link: https://patch.msgid.link/pndqzxqkt8u.a.out@axis.com
Signed-off-by: Mark Brown <broonie@kernel.org>
drivers/spi/spi-nxp-fspi.c

index b92bfef47371faf2140242940c7d6d9d10b0c1f6..848fa9319e36d65e8152931324b8e34eb162f5d3 100644 (file)
@@ -1284,7 +1284,7 @@ static int nxp_fspi_probe(struct platform_device *pdev)
 
        ret = devm_add_action_or_reset(dev, nxp_fspi_cleanup, f);
        if (ret)
-               return dev_err_probe(dev, ret, "Failed to register nxp_fspi_cleanup\n");
+               return ret;
 
        return devm_spi_register_controller(&pdev->dev, ctlr);
 }