]> git.ipfire.org Git - thirdparty/kernel/stable.git/commitdiff
scsi: scsi_dh_emc: return success in clariion_std_inquiry()
authorDan Carpenter <dan.carpenter@oracle.com>
Tue, 21 Feb 2017 18:46:37 +0000 (21:46 +0300)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Sat, 21 Oct 2017 15:09:05 +0000 (17:09 +0200)
[ Upstream commit 4d7d39a18b8b81511f0b893b7d2203790bf8a58b ]

We accidentally return an uninitialized variable on success.

Fixes: b6ff1b14cdf4 ("[SCSI] scsi_dh: Update EMC handler")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Reviewed-by: Hannes Reinecke <hare@suse.de>
Signed-off-by: Martin K. Petersen <martin.petersen@oracle.com>
Signed-off-by: Sasha Levin <alexander.levin@verizon.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
drivers/scsi/device_handler/scsi_dh_emc.c

index e6fb97cb12f43a7128267702bf5d568699a80b3e..7c28dc1cb0dd3f46db668841113a125e3a930106 100644 (file)
@@ -456,7 +456,7 @@ static int clariion_prep_fn(struct scsi_device *sdev, struct request *req)
 static int clariion_std_inquiry(struct scsi_device *sdev,
                                struct clariion_dh_data *csdev)
 {
-       int err;
+       int err = SCSI_DH_OK;
        char *sp_model;
 
        err = send_inquiry_cmd(sdev, 0, csdev);