]> git.ipfire.org Git - thirdparty/systemd.git/commitdiff
Revert "test: call nvme-cli with --hostnqn= instead of the deprecated --hostid="
authorYu Watanabe <watanabe.yu+github@gmail.com>
Tue, 1 Apr 2025 09:58:43 +0000 (18:58 +0900)
committerYu Watanabe <watanabe.yu+github@gmail.com>
Tue, 1 Apr 2025 09:58:43 +0000 (18:58 +0900)
This reverts commit b8942f4ae2d121603544b8527a7faf7fc458562c.

As commented https://github.com/systemd/systemd/issues/36908#issuecomment-2768507373,
the usage of --hostnqn= is different from --hostid=.

test/units/TEST-84-STORAGETM.sh

index 0ae98a4c3205c7c764cfd10a821f5b5cdcc5fda5..db281963b26dd033e26958432f0dc25cd668e408 100755 (executable)
@@ -24,7 +24,7 @@ NVME_UUID="$(cat /proc/sys/kernel/random/uuid)"
 systemd-run -u teststoragetm.service -p Type=notify -p "Environment=SYSTEMD_NVME_UUID=${NVME_UUID:?}" /usr/lib/systemd/systemd-storagetm /var/tmp/storagetm.test --nqn=quux
 NVME_DEVICE="/dev/disk/by-id/nvme-uuid.${NVME_UUID:?}"
 
-nvme connect-all -vv -t tcp -a 127.0.0.1 -s 16858 --hostnqn="$(cat /proc/sys/kernel/random/uuid)"
+nvme connect-all -vv -t tcp -a 127.0.0.1 -s 16858 --hostid="$(cat /proc/sys/kernel/random/uuid)"
 udevadm wait --settle "$NVME_DEVICE"
 
 dd if="$NVME_DEVICE" bs=1024 | cmp /var/tmp/storagetm.test -