md: ignore discard return value

__blkdev_issue_discard() always returns 0, making all error checking at
call sites dead code.

Simplify md to only check !discard_bio by ignoring the
__blkdev_issue_discard() value.

Reviewed-by: Martin K. Petersen <martin.petersen@oracle.com>
Reviewed-by: Johannes Thumshirn <johannes.thumshirn@wdc.com>
Reviewed-by: Christoph Hellwig <hch@lst.de>
Signed-off-by: Chaitanya Kulkarni <kch@nvidia.com>
Signed-off-by: Jens Axboe <axboe@kernel.dk>

diff --git a/drivers/md/md.c b/drivers/md/md.c
index 59cd303548de8e4cda0fcca2334340bf4ebd9bd3..89c9e63a9139b3a05bcad034d4829bb23d7c5c3e 100644 (file)
--- a/drivers/md/md.c
+++ b/drivers/md/md.c
@@ -9179,8 +9179,8 @@ void md_submit_discard_bio(struct mddev *mddev, struct md_rdev *rdev,
 {
        struct bio *discard_bio = NULL;
 
-       if (__blkdev_issue_discard(rdev->bdev, start, size, GFP_NOIO,
-                       &discard_bio) || !discard_bio)
+       __blkdev_issue_discard(rdev->bdev, start, size, GFP_NOIO, &discard_bio);
+       if (!discard_bio)
                return;
 
        bio_chain(discard_bio, bio);