libcli/security: Make use of sids_contains_sid()

Signed-off-by: Joseph Sutton <josephsutton@catalyst.net.nz>
Reviewed-by: Andrew Bartlett <abartlet@samba.org>

diff --git a/libcli/security/util_sid.c b/libcli/security/util_sid.c
index 8b548199261a87db983552e654a7b9651f712e74..1b2ebaf9c5517d92818668571f6a1790e0a111d9 100644 (file)
--- a/libcli/security/util_sid.c
+++ b/libcli/security/util_sid.c
@@ -383,12 +383,11 @@ NTSTATUS add_sid_to_array(TALLOC_CTX *mem_ctx, const struct dom_sid *sid,
 NTSTATUS add_sid_to_array_unique(TALLOC_CTX *mem_ctx, const struct dom_sid *sid,
                                 struct dom_sid **sids, uint32_t *num_sids)
 {
-       uint32_t i;
+       bool contains;
 
-       for (i=0; i<(*num_sids); i++) {
-               if (dom_sid_equal(sid, &(*sids)[i])) {
-                       return NT_STATUS_OK;
-               }
+       contains = sids_contains_sid(*sids, *num_sids, sid);
+       if (contains) {
+               return NT_STATUS_OK;
        }
 
        return add_sid_to_array(mem_ctx, sid, sids, num_sids);