Fix debugfs's icheck to correctly report the owner of an EA block

Hello Ted,
here is a minor fixup with debugfs "icheck" finding a block in an EA.
It was reporting the inode number as one too low because it was set
after the EA check is done.

From: Andreas Dilger <adilger@clusterfs.com>
Signed-off-by: "Theodore Ts'o" <tytso@mit.edu>

diff --git a/debugfs/ChangeLog b/debugfs/ChangeLog
index 3d7193d09e27a0bc30b476e61198d684689259dd..f5bc001299af752f154cef0fb8f4e405c1bddacf 100644 (file)
--- a/debugfs/ChangeLog
+++ b/debugfs/ChangeLog
@@ -1,3 +1,8 @@
+2006-03-08  Theodore Ts'o  <tytso@mit.edu>
+
+       * Fix bug in icheck which incorrectly reports the last valid inode
+               number as the owner for an EA block.
+
 2005-12-10  Theodore Ts'o  <tytso@mit.edu>
 
        * debugfs.c, debugfs.h, logdump.c, ls.c: Clean up various gcc

diff --git a/debugfs/icheck.c b/debugfs/icheck.c
index 6c4b0a111939f7d7c6825facde044bf3bda1c4bc..e3646def4131b9404b8f4cdb375c9c7d0ce32522 100644 (file)
--- a/debugfs/icheck.c
+++ b/debugfs/icheck.c
@@ -109,6 +109,8 @@ void do_icheck(int argc, char **argv)
                if (!inode.i_links_count)
                        goto next;
 
+               bw.inode = ino;
+
                if (inode.i_file_acl) {
                        icheck_proc(current_fs, &inode.i_file_acl, 0,
                                    0, 0, &bw);
@@ -125,8 +127,6 @@ void do_icheck(int argc, char **argv)
                if (inode.i_dtime)
                        goto next;
 
-               bw.inode = ino;
-
                retval = ext2fs_block_iterate2(current_fs, ino, 0, block_buf,
                                               icheck_proc, &bw);
                if (retval) {