]> git.ipfire.org Git - thirdparty/samba.git/commitdiff
s4:kdc:db-glue-tests Fix CID 1666664
authorGary Lockyer <gary@catalyst.net.nz>
Sun, 12 Oct 2025 20:44:49 +0000 (09:44 +1300)
committerMartin Schwenke <martins@samba.org>
Mon, 13 Oct 2025 03:39:34 +0000 (03:39 +0000)
Fix Coverity issue CID 1666664

115      char* ts = ldb_timestring(msg, created);
>>>     CID 1666664:         Null pointer dereferences  (NULL_RETURNS)
>>>     Dereferencing a pointer that might be "NULL" "ts" when calling
>>>     "ldb_msg_add_string".
116      ldb_msg_add_string(msg, "whenCreated", ts);

Signed-off-by: Gary Lockyer <gary@catalyst.net.nz>
Reviewed-by: Martin Schwenke <martin@meltin.net>
source4/kdc/tests/db-glue-test.c

index d98b143779df30134a9e0531b8f42093210d6a45..2ff528b129cd2aa4d1e5c25f2fb7eeb7fc9af255 100644 (file)
@@ -113,6 +113,7 @@ static void add_whenCreated(struct ldb_message *msg,
                            time_t created)
 {
        char* ts = ldb_timestring(msg, created);
+       assert_non_null(ts);
        ldb_msg_add_string(msg, "whenCreated", ts);
 }