iio: temperature: ltc2983: Use local device pointer consistently

Some functions define a local 'dev' pointer but still use bare
'&st->spi->dev' in some code paths, and some don't have it at all.
Replace bare references with the local pointer for consistency and
collapse some wrapped lines that now fit within 80 characters.

Reviewed-by: Joshua Crofts <joshua.crofts1@gmail.com>
Signed-off-by: Liviu Stan <liviu.stan@analog.com>
Signed-off-by: Jonathan Cameron <jic23@kernel.org>

diff --git a/drivers/iio/temperature/ltc2983.c b/drivers/iio/temperature/ltc2983.c
index 4bae90f03002de571e4b55709a9d541bfd3609b2..8b0b6b4884f6155c9646227b316903729ad11d2e 100644 (file)
--- a/drivers/iio/temperature/ltc2983.c
+++ b/drivers/iio/temperature/ltc2983.c
@@ -351,11 +351,11 @@ static int __ltc2983_chan_assign_common(struct ltc2983_data *st,
                                        const struct ltc2983_sensor *sensor,
                                        u32 chan_val)
 {
+       struct device *dev = &st->spi->dev;
        u32 reg = LTC2983_CHAN_ASSIGN_ADDR(sensor->chan);
 
        chan_val |= LTC2983_CHAN_TYPE(sensor->type);
-       dev_dbg(&st->spi->dev, "Assign reg:0x%04X, val:0x%08X\n", reg,
-               chan_val);
+       dev_dbg(dev, "Assign reg:0x%04X, val:0x%08X\n", reg, chan_val);
        st->chan_val = cpu_to_be32(chan_val);
        return regmap_bulk_write(st->regmap, reg, &st->chan_val,
                                 sizeof(st->chan_val));
@@ -656,11 +656,12 @@ static struct ltc2983_sensor *
 ltc2983_thermocouple_new(const struct fwnode_handle *child, struct ltc2983_data *st,
                         const struct ltc2983_sensor *sensor)
 {
+       struct device *dev = &st->spi->dev;
        struct ltc2983_thermocouple *thermo;
        u32 oc_current;
        int ret;
 
-       thermo = devm_kzalloc(&st->spi->dev, sizeof(*thermo), GFP_KERNEL);
+       thermo = devm_kzalloc(dev, sizeof(*thermo), GFP_KERNEL);
        if (!thermo)
                return ERR_PTR(-ENOMEM);
 
@@ -687,7 +688,7 @@ ltc2983_thermocouple_new(const struct fwnode_handle *child, struct ltc2983_data
                                        LTC2983_THERMOCOUPLE_OC_CURR(3);
                        break;
                default:
-                       return dev_err_ptr_probe(&st->spi->dev, -EINVAL,
+                       return dev_err_ptr_probe(dev, -EINVAL,
                                                 "Invalid open circuit current:%u\n",
                                                 oc_current);
                }
@@ -697,7 +698,7 @@ ltc2983_thermocouple_new(const struct fwnode_handle *child, struct ltc2983_data
        /* validate channel index */
        if (!(thermo->sensor_config & LTC2983_THERMOCOUPLE_DIFF_MASK) &&
            sensor->chan < LTC2983_DIFFERENTIAL_CHAN_MIN)
-               return dev_err_ptr_probe(&st->spi->dev, -EINVAL,
+               return dev_err_ptr_probe(dev, -EINVAL,
                                         "Invalid chann:%d for differential thermocouple\n",
                                         sensor->chan);
 
@@ -712,7 +713,7 @@ ltc2983_thermocouple_new(const struct fwnode_handle *child, struct ltc2983_data
                         * This would be caught later but we can just return
                         * the error right away.
                         */
-                       return dev_err_ptr_probe(&st->spi->dev, ret,
+                       return dev_err_ptr_probe(dev, ret,
                                                 "Property reg must be given\n");
        }
 
@@ -823,7 +824,7 @@ ltc2983_rtd_new(const struct fwnode_handle *child, struct ltc2983_data *st,
        } else {
                /* same as differential case */
                if (sensor->chan < LTC2983_DIFFERENTIAL_CHAN_MIN)
-                       return dev_err_ptr_probe(&st->spi->dev, -EINVAL,
+                       return dev_err_ptr_probe(dev, -EINVAL,
                                                 "Invalid chann:%d for RTD\n",
                                                 sensor->chan);
        }
@@ -873,7 +874,7 @@ ltc2983_rtd_new(const struct fwnode_handle *child, struct ltc2983_data *st,
                        rtd->excitation_current = 0x08;
                        break;
                default:
-                       return dev_err_ptr_probe(&st->spi->dev, -EINVAL,
+                       return dev_err_ptr_probe(dev, -EINVAL,
                                                 "Invalid value for excitation current(%u)\n",
                                                 excitation_current);
                }
@@ -922,7 +923,7 @@ ltc2983_thermistor_new(const struct fwnode_handle *child, struct ltc2983_data *s
        /* validate channel index */
        if (!(thermistor->sensor_config & LTC2983_THERMISTOR_DIFF_MASK) &&
            sensor->chan < LTC2983_DIFFERENTIAL_CHAN_MIN)
-               return dev_err_ptr_probe(&st->spi->dev, -EINVAL,
+               return dev_err_ptr_probe(dev, -EINVAL,
                                         "Invalid chann:%d for differential thermistor\n",
                                         sensor->chan);
 
@@ -964,7 +965,7 @@ ltc2983_thermistor_new(const struct fwnode_handle *child, struct ltc2983_data *s
                case 0:
                        /* auto range */
                        if (sensor->type >= LTC2983_SENSOR_THERMISTOR_STEINHART)
-                               return dev_err_ptr_probe(&st->spi->dev, -EINVAL,
+                               return dev_err_ptr_probe(dev, -EINVAL,
                                                         "Auto Range not allowed for custom sensors\n");
 
                        thermistor->excitation_current = 0x0c;
@@ -1003,7 +1004,7 @@ ltc2983_thermistor_new(const struct fwnode_handle *child, struct ltc2983_data *s
                        thermistor->excitation_current = 0x0b;
                        break;
                default:
-                       return dev_err_ptr_probe(&st->spi->dev, -EINVAL,
+                       return dev_err_ptr_probe(dev, -EINVAL,
                                                 "Invalid value for excitation current(%u)\n",
                                                 excitation_current);
                }
@@ -1016,11 +1017,12 @@ static struct ltc2983_sensor *
 ltc2983_diode_new(const struct fwnode_handle *child, const struct ltc2983_data *st,
                  const struct ltc2983_sensor *sensor)
 {
+       struct device *dev = &st->spi->dev;
        struct ltc2983_diode *diode;
        u32 temp = 0, excitation_current = 0;
        int ret;
 
-       diode = devm_kzalloc(&st->spi->dev, sizeof(*diode), GFP_KERNEL);
+       diode = devm_kzalloc(dev, sizeof(*diode), GFP_KERNEL);
        if (!diode)
                return ERR_PTR(-ENOMEM);
 
@@ -1036,7 +1038,7 @@ ltc2983_diode_new(const struct fwnode_handle *child, const struct ltc2983_data *
        /* validate channel index */
        if (!(diode->sensor_config & LTC2983_DIODE_DIFF_MASK) &&
            sensor->chan < LTC2983_DIFFERENTIAL_CHAN_MIN)
-               return dev_err_ptr_probe(&st->spi->dev, -EINVAL,
+               return dev_err_ptr_probe(dev, -EINVAL,
                                         "Invalid chann:%d for differential thermistor\n",
                                         sensor->chan);
 
@@ -1061,7 +1063,7 @@ ltc2983_diode_new(const struct fwnode_handle *child, const struct ltc2983_data *
                        diode->excitation_current = 0x03;
                        break;
                default:
-                       return dev_err_ptr_probe(&st->spi->dev, -EINVAL,
+                       return dev_err_ptr_probe(dev, -EINVAL,
                                                 "Invalid value for excitation current(%u)\n",
                                                 excitation_current);
                }
@@ -1079,23 +1081,24 @@ static struct ltc2983_sensor *ltc2983_r_sense_new(struct fwnode_handle *child,
                                        struct ltc2983_data *st,
                                        const struct ltc2983_sensor *sensor)
 {
+       struct device *dev = &st->spi->dev;
        struct ltc2983_rsense *rsense;
        int ret;
        u32 temp;
 
-       rsense = devm_kzalloc(&st->spi->dev, sizeof(*rsense), GFP_KERNEL);
+       rsense = devm_kzalloc(dev, sizeof(*rsense), GFP_KERNEL);
        if (!rsense)
                return ERR_PTR(-ENOMEM);
 
        /* validate channel index */
        if (sensor->chan < LTC2983_DIFFERENTIAL_CHAN_MIN)
-               return dev_err_ptr_probe(&st->spi->dev, -EINVAL,
+               return dev_err_ptr_probe(dev, -EINVAL,
                                         "Invalid chann:%d for r_sense\n",
                                         sensor->chan);
 
        ret = fwnode_property_read_u32(child, "adi,rsense-val-milli-ohms", &temp);
        if (ret)
-               return dev_err_ptr_probe(&st->spi->dev, -EINVAL,
+               return dev_err_ptr_probe(dev, -EINVAL,
                                         "Property adi,rsense-val-milli-ohms missing\n");
        /*
         * Times 1000 because we have milli-ohms and __convert_to_raw
@@ -1115,9 +1118,10 @@ static struct ltc2983_sensor *ltc2983_adc_new(struct fwnode_handle *child,
                                         struct ltc2983_data *st,
                                         const struct ltc2983_sensor *sensor)
 {
+       struct device *dev = &st->spi->dev;
        struct ltc2983_adc *adc;
 
-       adc = devm_kzalloc(&st->spi->dev, sizeof(*adc), GFP_KERNEL);
+       adc = devm_kzalloc(dev, sizeof(*adc), GFP_KERNEL);
        if (!adc)
                return ERR_PTR(-ENOMEM);
 
@@ -1125,7 +1129,7 @@ static struct ltc2983_sensor *ltc2983_adc_new(struct fwnode_handle *child,
                adc->single_ended = true;
 
        if (!adc->single_ended && sensor->chan < LTC2983_DIFFERENTIAL_CHAN_MIN)
-               return dev_err_ptr_probe(&st->spi->dev, -EINVAL,
+               return dev_err_ptr_probe(dev, -EINVAL,
                                         "Invalid chan:%d for differential adc\n",
                                         sensor->chan);
 
@@ -1140,9 +1144,10 @@ static struct ltc2983_sensor *ltc2983_temp_new(struct fwnode_handle *child,
                                               struct ltc2983_data *st,
                                               const struct ltc2983_sensor *sensor)
 {
+       struct device *dev = &st->spi->dev;
        struct ltc2983_temp *temp;
 
-       temp = devm_kzalloc(&st->spi->dev, sizeof(*temp), GFP_KERNEL);
+       temp = devm_kzalloc(dev, sizeof(*temp), GFP_KERNEL);
        if (!temp)
                return ERR_PTR(-ENOMEM);
 
@@ -1150,7 +1155,7 @@ static struct ltc2983_sensor *ltc2983_temp_new(struct fwnode_handle *child,
                temp->single_ended = true;
 
        if (!temp->single_ended && sensor->chan < LTC2983_DIFFERENTIAL_CHAN_MIN)
-               return dev_err_ptr_probe(&st->spi->dev, -EINVAL,
+               return dev_err_ptr_probe(dev, -EINVAL,
                                         "Invalid chan:%d for differential temp\n",
                                         sensor->chan);
 
@@ -1169,13 +1174,14 @@ static struct ltc2983_sensor *ltc2983_temp_new(struct fwnode_handle *child,
 static int ltc2983_chan_read(struct ltc2983_data *st,
                        const struct ltc2983_sensor *sensor, int *val)
 {
+       struct device *dev = &st->spi->dev;
        u32 start_conversion = 0;
        int ret;
        unsigned long time;
 
        start_conversion = LTC2983_STATUS_START(true);
        start_conversion |= LTC2983_STATUS_CHAN_SEL(sensor->chan);
-       dev_dbg(&st->spi->dev, "Start conversion on chan:%d, status:%02X\n",
+       dev_dbg(dev, "Start conversion on chan:%d, status:%02X\n",
                sensor->chan, start_conversion);
        reinit_completion(&st->completion);
        /* start conversion */
@@ -1191,7 +1197,7 @@ static int ltc2983_chan_read(struct ltc2983_data *st,
        time = wait_for_completion_timeout(&st->completion,
                                           msecs_to_jiffies(300));
        if (!time) {
-               dev_warn(&st->spi->dev, "Conversion timed out\n");
+               dev_warn(dev, "Conversion timed out\n");
                return -ETIMEDOUT;
        }
 
@@ -1204,7 +1210,7 @@ static int ltc2983_chan_read(struct ltc2983_data *st,
        *val = __be32_to_cpu(st->temp);
 
        if (!(LTC2983_RES_VALID_MASK & *val)) {
-               dev_err(&st->spi->dev, "Invalid conversion detected\n");
+               dev_err(dev, "Invalid conversion detected\n");
                return -EIO;
        }
 
@@ -1221,12 +1227,12 @@ static int ltc2983_read_raw(struct iio_dev *indio_dev,
                            int *val, int *val2, long mask)
 {
        struct ltc2983_data *st = iio_priv(indio_dev);
+       struct device *dev = &st->spi->dev;
        int ret;
 
        /* sanity check */
        if (chan->address >= st->num_channels) {
-               dev_err(&st->spi->dev, "Invalid chan address:%ld",
-                       chan->address);
+               dev_err(dev, "Invalid chan address:%ld", chan->address);
                return -EINVAL;
        }
 
@@ -1302,7 +1308,7 @@ static int ltc2983_parse_fw(struct ltc2983_data *st)
 
        st->num_channels = device_get_child_node_count(dev);
        if (!st->num_channels)
-               return dev_err_probe(&st->spi->dev, -EINVAL,
+               return dev_err_probe(dev, -EINVAL,
                                     "At least one channel must be given!\n");
 
        st->sensors = devm_kcalloc(dev, st->num_channels, sizeof(*st->sensors),
@@ -1390,6 +1396,7 @@ static int ltc2983_eeprom_cmd(struct ltc2983_data *st, unsigned int cmd,
                              unsigned int wait_time, unsigned int status_reg,
                              unsigned long status_fail_mask)
 {
+       struct device *dev = &st->spi->dev;
        unsigned long time;
        unsigned int val;
        int ret;
@@ -1409,7 +1416,7 @@ static int ltc2983_eeprom_cmd(struct ltc2983_data *st, unsigned int cmd,
        time = wait_for_completion_timeout(&st->completion,
                                           msecs_to_jiffies(wait_time));
        if (!time)
-               return dev_err_probe(&st->spi->dev, -ETIMEDOUT,
+               return dev_err_probe(dev, -ETIMEDOUT,
                                     "EEPROM command timed out\n");
 
        ret = regmap_read(st->regmap, status_reg, &val);
@@ -1417,7 +1424,7 @@ static int ltc2983_eeprom_cmd(struct ltc2983_data *st, unsigned int cmd,
                return ret;
 
        if (val & status_fail_mask)
-               return dev_err_probe(&st->spi->dev, -EINVAL,
+               return dev_err_probe(dev, -EINVAL,
                                     "EEPROM command failed: 0x%02X\n", val);
 
        return 0;
@@ -1426,6 +1433,7 @@ static int ltc2983_eeprom_cmd(struct ltc2983_data *st, unsigned int cmd,
 static int ltc2983_setup(struct ltc2983_data *st, bool assign_iio)
 {
        u32 iio_chan_t = 0, iio_chan_v = 0, chan, iio_idx = 0, status;
+       struct device *dev = &st->spi->dev;
        int ret;
 
        /* make sure the device is up: start bit (7) is 0 and done bit (6) is 1 */
@@ -1433,8 +1441,7 @@ static int ltc2983_setup(struct ltc2983_data *st, bool assign_iio)
                                       LTC2983_STATUS_UP(status) == 1, 25000,
                                       25000 * 10);
        if (ret)
-               return dev_err_probe(&st->spi->dev, ret,
-                                    "Device startup timed out\n");
+               return dev_err_probe(dev, ret, "Device startup timed out\n");
 
        ret = regmap_update_bits(st->regmap, LTC2983_GLOBAL_CONFIG_REG,
                                 LTC2983_NOTCH_FREQ_MASK,
@@ -1534,12 +1541,13 @@ static const struct  iio_info ltc2983_iio_info = {
 
 static int ltc2983_probe(struct spi_device *spi)
 {
+       struct device *dev = &spi->dev;
        struct ltc2983_data *st;
        struct iio_dev *indio_dev;
        struct gpio_desc *gpio;
        int ret;
 
-       indio_dev = devm_iio_device_alloc(&spi->dev, sizeof(*st));
+       indio_dev = devm_iio_device_alloc(dev, sizeof(*st));
        if (!indio_dev)
                return -ENOMEM;
 
@@ -1551,7 +1559,7 @@ static int ltc2983_probe(struct spi_device *spi)
 
        st->regmap = devm_regmap_init_spi(spi, &ltc2983_regmap_config);
        if (IS_ERR(st->regmap))
-               return dev_err_probe(&spi->dev, PTR_ERR(st->regmap),
+               return dev_err_probe(dev, PTR_ERR(st->regmap),
                                     "Failed to initialize regmap\n");
 
        mutex_init(&st->lock);
@@ -1564,11 +1572,11 @@ static int ltc2983_probe(struct spi_device *spi)
        if (ret)
                return ret;
 
-       ret = devm_regulator_get_enable(&spi->dev, "vdd");
+       ret = devm_regulator_get_enable(dev, "vdd");
        if (ret)
                return ret;
 
-       gpio = devm_gpiod_get_optional(&st->spi->dev, "reset", GPIOD_OUT_HIGH);
+       gpio = devm_gpiod_get_optional(dev, "reset", GPIOD_OUT_HIGH);
        if (IS_ERR(gpio))
                return PTR_ERR(gpio);
 
@@ -1578,7 +1586,7 @@ static int ltc2983_probe(struct spi_device *spi)
                gpiod_set_value_cansleep(gpio, 0);
        }
 
-       st->iio_chan = devm_kzalloc(&spi->dev,
+       st->iio_chan = devm_kzalloc(dev,
                                    st->iio_channels * sizeof(*st->iio_chan),
                                    GFP_KERNEL);
        if (!st->iio_chan)
@@ -1588,11 +1596,10 @@ static int ltc2983_probe(struct spi_device *spi)
        if (ret)
                return ret;
 
-       ret = devm_request_irq(&spi->dev, spi->irq, ltc2983_irq_handler,
+       ret = devm_request_irq(dev, spi->irq, ltc2983_irq_handler,
                               IRQF_TRIGGER_RISING, st->info->name, st);
        if (ret)
-               return dev_err_probe(&spi->dev, ret,
-                                    "failed to request an irq\n");
+               return dev_err_probe(dev, ret, "failed to request an irq\n");
 
        if (st->info->has_eeprom) {
                ret = ltc2983_eeprom_cmd(st, LTC2983_EEPROM_WRITE_CMD,
@@ -1609,7 +1616,7 @@ static int ltc2983_probe(struct spi_device *spi)
        indio_dev->modes = INDIO_DIRECT_MODE;
        indio_dev->info = &ltc2983_iio_info;
 
-       return devm_iio_device_register(&spi->dev, indio_dev);
+       return devm_iio_device_register(dev, indio_dev);
 }
 
 static int ltc2983_resume(struct device *dev)