resolved: tests for dns_packet_set_flags()

diff --git a/src/resolve/meson.build b/src/resolve/meson.build
index 47383feec30b120a43d76fcfb58201591adb582e..b1fcb990af2c2c30e83d50f24c5ead74db44e2fe 100644 (file)
--- a/src/resolve/meson.build
+++ b/src/resolve/meson.build
@@ -165,6 +165,9 @@ executables += [
         resolve_test_template + {
                 'sources' : files('test-dns-packet.c'),
         },
+        resolve_test_template + {
+                'sources' : files('test-dns-packet-append.c'),
+        },
         resolve_test_template + {
                 'sources' : files('test-dns-packet-extract.c'),
         },

diff --git a/src/resolve/test-dns-packet-append.c b/src/resolve/test-dns-packet-append.c
new file mode 100644 (file)
index 0000000..c0c6a04
--- /dev/null
+++ b/src/resolve/test-dns-packet-append.c
@@ -0,0 +1,142 @@
+/* SPDX-License-Identifier: LGPL-2.1-or-later */
+
+#include "dns-type.h"
+#include "resolved-dns-packet.h"
+#include "resolved-dns-rr.h"
+
+#include "log.h"
+#include "tests.h"
+
+#define BIT_QR (1 << 7)
+#define BIT_AA (1 << 2)
+#define BIT_TC (1 << 1)
+#define BIT_RD (1 << 0)
+
+#define BIT_RA (1 << 7)
+#define BIT_AD (1 << 5)
+#define BIT_CD (1 << 4)
+
+/* ================================================================
+ * dns_packet_set_flags()
+ * ================================================================ */
+
+TEST(packet_set_flags_dns_checking_enabled) {
+        _cleanup_(dns_packet_unrefp) DnsPacket *packet = NULL;
+
+        ASSERT_OK(dns_packet_new(&packet, DNS_PROTOCOL_DNS, 0, DNS_PACKET_SIZE_MAX));
+        ASSERT_NOT_NULL(packet);
+        dns_packet_set_flags(packet, /* dnssec_checking_disabled= */ false, /* truncated= */ false);
+
+        ASSERT_EQ(DNS_PACKET_QR(packet), 0);
+        ASSERT_EQ(DNS_PACKET_OPCODE(packet), 0);
+        ASSERT_EQ(DNS_PACKET_AA(packet), 0);
+        ASSERT_EQ(DNS_PACKET_TC(packet), 0);
+        ASSERT_EQ(DNS_PACKET_RD(packet), 1);
+
+        ASSERT_EQ(DNS_PACKET_RA(packet), 0);
+        ASSERT_EQ(DNS_PACKET_AD(packet), 0);
+        ASSERT_EQ(DNS_PACKET_CD(packet), 0);
+        ASSERT_EQ(DNS_PACKET_RCODE(packet), 0);
+}
+
+TEST(packet_set_flags_dns_checking_disabled) {
+        _cleanup_(dns_packet_unrefp) DnsPacket *packet = NULL;
+
+        ASSERT_OK(dns_packet_new(&packet, DNS_PROTOCOL_DNS, 0, DNS_PACKET_SIZE_MAX));
+        ASSERT_NOT_NULL(packet);
+        dns_packet_set_flags(packet, /* dnssec_checking_disabled= */ true, /* truncated= */ false);
+
+        ASSERT_EQ(DNS_PACKET_QR(packet), 0);
+        ASSERT_EQ(DNS_PACKET_OPCODE(packet), 0);
+        ASSERT_EQ(DNS_PACKET_AA(packet), 0);
+        ASSERT_EQ(DNS_PACKET_TC(packet), 0);
+        ASSERT_EQ(DNS_PACKET_RD(packet), 1);
+
+        ASSERT_EQ(DNS_PACKET_RA(packet), 0);
+        ASSERT_EQ(DNS_PACKET_AD(packet), 0);
+        ASSERT_EQ(DNS_PACKET_CD(packet), 1);
+        ASSERT_EQ(DNS_PACKET_RCODE(packet), 0);
+}
+
+TEST(packet_set_flags_llmnr) {
+        _cleanup_(dns_packet_unrefp) DnsPacket *packet = NULL;
+
+        ASSERT_OK(dns_packet_new(&packet, DNS_PROTOCOL_LLMNR, 0, DNS_PACKET_SIZE_MAX));
+        ASSERT_NOT_NULL(packet);
+        dns_packet_set_flags(packet, /* dnssec_checking_disabled= */ true, /* truncated= */ false);
+
+        ASSERT_EQ(DNS_PACKET_QR(packet), 0);
+        ASSERT_EQ(DNS_PACKET_OPCODE(packet), 0);
+        ASSERT_EQ(DNS_PACKET_AA(packet), 0);
+        ASSERT_EQ(DNS_PACKET_TC(packet), 0);
+        ASSERT_EQ(DNS_PACKET_RD(packet), 0);
+
+        ASSERT_EQ(DNS_PACKET_RA(packet), 0);
+        ASSERT_EQ(DNS_PACKET_AD(packet), 0);
+        ASSERT_EQ(DNS_PACKET_CD(packet), 0);
+        ASSERT_EQ(DNS_PACKET_RCODE(packet), 0);
+}
+
+TEST(packet_set_flags_mdns_not_truncated) {
+        _cleanup_(dns_packet_unrefp) DnsPacket *packet = NULL;
+
+        ASSERT_OK(dns_packet_new(&packet, DNS_PROTOCOL_MDNS, 0, DNS_PACKET_SIZE_MAX));
+        ASSERT_NOT_NULL(packet);
+        dns_packet_set_flags(packet, /* dnssec_checking_disabled= */ true, /* truncated= */ false);
+
+        ASSERT_EQ(DNS_PACKET_QR(packet), 0);
+        ASSERT_EQ(DNS_PACKET_OPCODE(packet), 0);
+        ASSERT_EQ(DNS_PACKET_AA(packet), 0);
+        ASSERT_EQ(DNS_PACKET_TC(packet), 0);
+        ASSERT_EQ(DNS_PACKET_RD(packet), 0);
+
+        ASSERT_EQ(DNS_PACKET_RA(packet), 0);
+        ASSERT_EQ(DNS_PACKET_AD(packet), 0);
+        ASSERT_EQ(DNS_PACKET_CD(packet), 0);
+        ASSERT_EQ(DNS_PACKET_RCODE(packet), 0);
+}
+
+TEST(packet_set_flags_mdns_truncated) {
+        _cleanup_(dns_packet_unrefp) DnsPacket *packet = NULL;
+
+        ASSERT_OK(dns_packet_new(&packet, DNS_PROTOCOL_MDNS, 0, DNS_PACKET_SIZE_MAX));
+        ASSERT_NOT_NULL(packet);
+        dns_packet_set_flags(packet, /* dnssec_checking_disabled= */ true, /* truncated= */ true);
+
+        ASSERT_EQ(DNS_PACKET_QR(packet), 0);
+        ASSERT_EQ(DNS_PACKET_OPCODE(packet), 0);
+        ASSERT_EQ(DNS_PACKET_AA(packet), 0);
+        ASSERT_EQ(DNS_PACKET_TC(packet), 1);
+        ASSERT_EQ(DNS_PACKET_RD(packet), 0);
+
+        ASSERT_EQ(DNS_PACKET_RA(packet), 0);
+        ASSERT_EQ(DNS_PACKET_AD(packet), 0);
+        ASSERT_EQ(DNS_PACKET_CD(packet), 0);
+        ASSERT_EQ(DNS_PACKET_RCODE(packet), 0);
+}
+
+/* ================================================================
+ * dns_packet_new_query()
+ * ================================================================ */
+
+TEST(packet_new_query_checking_enabled) {
+        _cleanup_(dns_packet_unrefp) DnsPacket *packet = NULL;
+
+        ASSERT_OK(dns_packet_new_query(&packet, DNS_PROTOCOL_DNS, 0, false));
+        ASSERT_NOT_NULL(packet);
+
+        ASSERT_EQ(DNS_PACKET_TC(packet), 0);
+        ASSERT_EQ(DNS_PACKET_CD(packet), 0);
+}
+
+TEST(packet_new_query_checking_disabled) {
+        _cleanup_(dns_packet_unrefp) DnsPacket *packet = NULL;
+
+        ASSERT_OK(dns_packet_new_query(&packet, DNS_PROTOCOL_DNS, 0, true));
+        ASSERT_NOT_NULL(packet);
+
+        ASSERT_EQ(DNS_PACKET_TC(packet), 0);
+        ASSERT_EQ(DNS_PACKET_CD(packet), 1);
+}
+
+DEFINE_TEST_MAIN(LOG_DEBUG)