]> git.ipfire.org Git - thirdparty/Python/cpython.git/commitdiff
Issue #19857: Make sure that test_imaplib reaps server threads even in face of
authorCharles-François Natali <cf.natali@gmail.com>
Sat, 7 Dec 2013 19:30:17 +0000 (20:30 +0100)
committerCharles-François Natali <cf.natali@gmail.com>
Sat, 7 Dec 2013 19:30:17 +0000 (20:30 +0100)
error upon client disconnection.

Lib/test/test_imaplib.py

index daa8afeec55e770e9d2052745b46e6fcf0f0b381..7c9afd9f39fb1a72d173caf0cc5c56176c1e9bdb 100644 (file)
@@ -210,13 +210,12 @@ class BaseThreadedNetworkedTests(unittest.TestCase):
 
     @contextmanager
     def reaped_pair(self, hdlr):
-        server, thread = self.make_server((support.HOST, 0), hdlr)
-        client = self.imap_class(*server.server_address)
-        try:
-            yield server, client
-        finally:
-            client.logout()
-            self.reap_server(server, thread)
+        with self.reaped_server(hdlr) as server:
+            client = self.imap_class(*server.server_address)
+            try:
+                yield server, client
+            finally:
+                client.logout()
 
     @reap_threads
     def test_connect(self):