]> git.ipfire.org Git - thirdparty/kernel/stable-queue.git/commitdiff
4.4-stable patches
authorGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Apr 2020 15:08:38 +0000 (17:08 +0200)
committerGreg Kroah-Hartman <gregkh@linuxfoundation.org>
Thu, 30 Apr 2020 15:08:38 +0000 (17:08 +0200)
added patches:
perf-core-fix-parent-pid-tid-in-task-exit-events.patch

queue-4.4/perf-core-fix-parent-pid-tid-in-task-exit-events.patch [new file with mode: 0644]
queue-4.4/series

diff --git a/queue-4.4/perf-core-fix-parent-pid-tid-in-task-exit-events.patch b/queue-4.4/perf-core-fix-parent-pid-tid-in-task-exit-events.patch
new file mode 100644 (file)
index 0000000..a5b6806
--- /dev/null
@@ -0,0 +1,59 @@
+From f3bed55e850926614b9898fe982f66d2541a36a5 Mon Sep 17 00:00:00 2001
+From: Ian Rogers <irogers@google.com>
+Date: Fri, 17 Apr 2020 11:28:42 -0700
+Subject: perf/core: fix parent pid/tid in task exit events
+
+From: Ian Rogers <irogers@google.com>
+
+commit f3bed55e850926614b9898fe982f66d2541a36a5 upstream.
+
+Current logic yields the child task as the parent.
+
+Before:
+$ perf record bash -c "perf list > /dev/null"
+$ perf script -D |grep 'FORK\|EXIT'
+4387036190981094 0x5a70 [0x30]: PERF_RECORD_FORK(10472:10472):(10470:10470)
+4387036606207580 0xf050 [0x30]: PERF_RECORD_EXIT(10472:10472):(10472:10472)
+4387036607103839 0x17150 [0x30]: PERF_RECORD_EXIT(10470:10470):(10470:10470)
+                                                   ^
+  Note the repeated values here -------------------/
+
+After:
+383281514043 0x9d8 [0x30]: PERF_RECORD_FORK(2268:2268):(2266:2266)
+383442003996 0x2180 [0x30]: PERF_RECORD_EXIT(2268:2268):(2266:2266)
+383451297778 0xb70 [0x30]: PERF_RECORD_EXIT(2266:2266):(2265:2265)
+
+Fixes: 94d5d1b2d891 ("perf_counter: Report the cloning task as parent on perf_counter_fork()")
+Reported-by: KP Singh <kpsingh@google.com>
+Signed-off-by: Ian Rogers <irogers@google.com>
+Signed-off-by: Peter Zijlstra (Intel) <peterz@infradead.org>
+Link: https://lkml.kernel.org/r/20200417182842.12522-1-irogers@google.com
+Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
+
+---
+ kernel/events/core.c |   13 ++++++++++---
+ 1 file changed, 10 insertions(+), 3 deletions(-)
+
+--- a/kernel/events/core.c
++++ b/kernel/events/core.c
+@@ -5810,10 +5810,17 @@ static void perf_event_task_output(struc
+               goto out;
+       task_event->event_id.pid = perf_event_pid(event, task);
+-      task_event->event_id.ppid = perf_event_pid(event, current);
+-
+       task_event->event_id.tid = perf_event_tid(event, task);
+-      task_event->event_id.ptid = perf_event_tid(event, current);
++
++      if (task_event->event_id.header.type == PERF_RECORD_EXIT) {
++              task_event->event_id.ppid = perf_event_pid(event,
++                                                      task->real_parent);
++              task_event->event_id.ptid = perf_event_pid(event,
++                                                      task->real_parent);
++      } else {  /* PERF_RECORD_FORK */
++              task_event->event_id.ppid = perf_event_pid(event, current);
++              task_event->event_id.ptid = perf_event_tid(event, current);
++      }
+       task_event->event_id.time = perf_event_clock(event);
index 372d53a95043da8d4520d77561bc979d4da6f6a6..bddab79396f737463ec886f84df02fa5520243f1 100644 (file)
@@ -57,3 +57,4 @@ fuse-fix-possibly-missed-wake-up-after-abort.patch
 mtd-cfi-fix-deadloop-in-cfi_cmdset_0002.c-do_write_buffer.patch
 usb-gadget-udc-bdc-remove-unnecessary-null-checks-in-bdc_req_complete.patch
 net-cxgb4-check-the-return-from-t4_query_params-properly.patch
+perf-core-fix-parent-pid-tid-in-task-exit-events.patch